fix reviews

Signed-off-by: Ray Cao <zisong.cw@alibaba-inc.com>

Author: RayaCoo

src/aof.c

@@ -1007,7 +1007,7 @@ int startAppendOnly(void) {
 
 /* try to Restart AOF after a successful primary-replica full SYNC with
  * existing RDB file. */
-int tryRestartAOFAfterSYNCWithRdb(void) {
+int RestartAOFWithSyncFile(void) {
     serverAssert(server.aof_state == AOF_OFF);
 
     int newfd = -1, rdbfile_renamed = 0;
@@ -1112,9 +1112,7 @@ int tryRestartAOFAfterSYNCWithRdb(void) {
         }
     }
     if (temp_am) aofManifestFree(temp_am);
-    if (new_base_filename) sdsfree(new_base_filename);
     if (new_base_filepath) sdsfree(new_base_filepath);
-    if (new_incr_filename) sdsfree(new_incr_filename);
     if (new_incr_filepath) sdsfree(new_incr_filepath);
     if (newfd != -1) close(newfd);
     return C_ERR;

src/replication.c

@@ -2524,7 +2524,7 @@ void readSyncBulkPayload(connection *conn) {
     /* Restart the AOF subsystem now that we finished the sync. This
      * will trigger an AOF rewrite, and when done will start appending
      * to the new file. */
-    if (!use_diskless_load && server.aof_enabled && server.aof_use_rdb_preamble) tryRestartAOFAfterSYNCWithRdb();
+    if (!use_diskless_load && server.aof_enabled && server.aof_use_rdb_preamble) RestartAOFWithSyncFile();
 
     if (server.aof_enabled && server.aof_state == AOF_OFF) restartAOFAfterSYNC();
 

src/server.h

@@ -2984,7 +2984,7 @@ int rewriteAppendOnlyFileBackground(void);
 int loadAppendOnlyFiles(aofManifest *am);
 void stopAppendOnly(void);
 int startAppendOnly(void);
-int tryRestartAOFAfterSYNCWithRdb(void);
+int RestartAOFWithSyncFile(void);
 void backgroundRewriteDoneHandler(int exitcode, int bysignal);
 void killAppendOnlyChild(void);
 void restartAOFAfterSYNC(void);