Skip to content

Commit ee5b72b

Browse files
authored
Fix dual-channel-replication test due to typo error and stabilize it (valkey-io#2386)
It should not be a negative value, otherwise we lose the meaning of delay and the rdb generation may finish too fast in a fast machine and cause the test to fail. Also, the max_tries number is increased and the loading-process-events-interval-bytes is adjusted so that the replica has more opportunities to process the events and can be aware of the disconnection. Signed-off-by: Binbin <binloveplay1314@qq.com>
1 parent a481fe2 commit ee5b72b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/integration/dual-channel-replication.tcl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,17 +1291,18 @@ start_server {tags {"dual-channel-replication external:skip"}} {
12911291

12921292
# Generating RDB will take 100 sec to generate
12931293
$primary debug populate 1000000 primary 1
1294-
$primary config set rdb-key-save-delay -10
1294+
$primary config set rdb-key-save-delay 10
12951295

12961296
start_server {} {
12971297
set replica [srv 0 client]
12981298
set replica_host [srv 0 host]
12991299
set replica_port [srv 0 port]
13001300
set replica_log [srv 0 stdout]
1301-
1301+
13021302
$replica config set dual-channel-replication-enabled yes
13031303
$replica config set loglevel debug
13041304
$replica config set repl-diskless-load flush-before-load
1305+
$replica config set loading-process-events-interval-bytes 1024
13051306

13061307
if {$::valgrind} {
13071308
$primary config set repl-timeout 100
@@ -1310,7 +1311,7 @@ start_server {tags {"dual-channel-replication external:skip"}} {
13101311
} else {
13111312
$primary config set repl-timeout 10
13121313
$replica config set repl-timeout 10
1313-
set max_tries 500
1314+
set max_tries 1000
13141315
}
13151316

13161317
test "Replica notice main-connection killed during rdb load callback" {; # https://github.com/valkey-io/valkey/issues/1152

0 commit comments

Comments
 (0)