Skip to content

Commit dcbf1f9

Browse files
attach.required not yet available in 3.5.0
1 parent 68c6a38 commit dcbf1f9

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

inst/tests/other.Rraw

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
pkgs = c("DBI", "RSQLite", "bit64", "caret", "dplyr", "gdata", "ggplot2", "hexbin", "knitr", "nanotime", "nlme", "parallel", "plyr", "R.utils", "sf", "vctrs", "xts", "yaml", "zoo")
1+
pkgs = c("DBI", "RSQLite", "bit64", "ggplot2", "caret", "dplyr", "gdata", "hexbin", "knitr", "nanotime", "nlme", "parallel", "plyr", "R.utils", "sf", "vctrs", "zoo", "xts", "yaml")
22
# First expression of this file must be as above: .gitlab-ci.yml uses parse(,n=1L) to read one expression from this file and installs pkgs.
33
# So that these dependencies of other.Rraw are maintained in a single place.
44
# TEST_DATA_TABLE_WITH_OTHER_PACKAGES is off by default so this other.Rraw doesn't run on CRAN. It is run by GLCI, locally in dev, and by
55
# users running test.data.table("other.Rraw").
6-
# zoo needs to be before xts for #5101 otherwise xts's dependency zoo gets attached at position 2 if xts is loaded first
6+
# TODO(R>=3.6.0): use attach.required=FALSE to let us keep pkgs= in alphabetical order (https://stat.ethz.ch/pipermail/r-devel/2026-July/084630.html)
77

88
# Optional Suggest-ed package tests moved from tests.Rraw to here in #5516. Retaining their comments:
99
# "xts", # we have xts methods in R/xts.R
@@ -26,10 +26,8 @@ INT = data.table:::INT
2626

2727
if (anyDuplicated(pkgs)) stop("Packages defined to be loaded for integration tests in 'inst/tests/other.Rraw' contains duplicates.")
2828

29-
# attach at the end for #5101;
30-
# attach.required=FALSE for Depends resolution order (see https://stat.ethz.ch/pipermail/r-devel/2026-July/084630.html)
3129
f = function(pkg) suppressWarnings(suppressMessages(isTRUE(
32-
library(pkg, character.only=TRUE, logical.return=TRUE, warn.conflicts=FALSE, pos="package:base", attach.required=FALSE)
30+
library(pkg, character.only=TRUE, logical.return=TRUE, warn.conflicts=FALSE, pos="package:base") # attach at the end for #5101
3331
)))
3432
loaded = sapply(pkgs, f)
3533
if (!all(loaded)) {

0 commit comments

Comments
 (0)