Skip to content

Commit 3f386be

Browse files
authored
3.x: Fix recent groupBy tests sometimes failing with MBE (#6994)
1 parent c693edb commit 3f386be

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

Diff for: src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableGroupByTest.java

+8-12
Original file line numberDiff line numberDiff line change
@@ -2719,10 +2719,9 @@ public void issue6974Part2Case1ObserveOn() {
27192719
// .take(10)
27202720
.take(10, TimeUnit.MILLISECONDS)
27212721
, flatMapMaxConcurrency)
2722-
.test()
2722+
.subscribeWith(new TestSubscriberEx<>())
27232723
.awaitDone(5, TimeUnit.SECONDS)
2724-
.assertNoErrors()
2725-
.assertComplete();
2724+
.assertTerminated(); // MBE is possible if the async group closing is slow
27262725
}
27272726

27282727
@Test
@@ -2746,10 +2745,9 @@ public void issue6974Part2Case1ObserveOnHide() {
27462745
// .take(10)
27472746
.take(10, TimeUnit.MILLISECONDS)
27482747
, flatMapMaxConcurrency)
2749-
.test()
2748+
.subscribeWith(new TestSubscriberEx<>())
27502749
.awaitDone(5, TimeUnit.SECONDS)
2751-
.assertNoErrors()
2752-
.assertComplete();
2750+
.assertTerminated(); // MBE is possible if the async group closing is slow
27532751
}
27542752

27552753
@Test
@@ -2834,10 +2832,9 @@ public void issue6974Part2Case1ObserveOnConditional() {
28342832
// .take(10)
28352833
.take(10, TimeUnit.MILLISECONDS)
28362834
, flatMapMaxConcurrency)
2837-
.test()
2835+
.subscribeWith(new TestSubscriberEx<>())
28382836
.awaitDone(5, TimeUnit.SECONDS)
2839-
.assertNoErrors()
2840-
.assertComplete();
2837+
.assertTerminated(); // MBE is possible if the async group closing is slow
28412838
}
28422839

28432840
@Test
@@ -2862,10 +2859,9 @@ public void issue6974Part2Case1ObserveOnConditionalHide() {
28622859
// .take(10)
28632860
.take(10, TimeUnit.MILLISECONDS)
28642861
, flatMapMaxConcurrency)
2865-
.test()
2862+
.subscribeWith(new TestSubscriberEx<>())
28662863
.awaitDone(5, TimeUnit.SECONDS)
2867-
.assertNoErrors()
2868-
.assertComplete();
2864+
.assertTerminated(); // MBE is possible if the async group closing is slow
28692865
}
28702866

28712867
/*

0 commit comments

Comments
 (0)