Skip to content

[Repo Assist] Fix ruff lint issues in test_scheduler; remove test_subject/test_scheduler from ruff exclude; standardise setup-python@v5Β #753

Description

@github-actions

πŸ€– This is an automated pull request from Repo Assist, an AI assistant for this repository.

Summary

This PR addresses two tasks:

Task 9 β€” Testing Improvements: tests/test_scheduler/ had 8 ruff lint errors preventing it from being removed from the lint exclude list. tests/test_subject/ already passed all checks but was still excluded.

Task 4 β€” Engineering Investments: The code-quality CI job used actions/setup-python@v4 while all other jobs used @v5 β€” now consistent.

Changes

tests/test_scheduler/ β€” ruff fixes

File Error Fix
test_asyncioscheduler.py I001 unsorted imports Reordered imports
test_ioloopscheduler.py E402 post-importorskip import Added # noqa: E402
test_twistedscheduler.py E402 post-importorskip imports Added # noqa: E402
test_gtkscheduler.py E402 + I001 post-importorskip import Added # noqa: E402, I001
test_historicalscheduler.py UP031 %-format, UP004 object base f-strings, removed object

pyproject.toml

Removed tests/test_subject and tests/test_scheduler from the [tool.ruff] exclude list. Both directories now pass ruff check cleanly.

The [tool.pyright] exclude list is unchanged β€” these directories have strict-mode pyright issues that need separate attention.

.github/workflows/python-package.yml

Changed actions/setup-python@v4 β†’ @v5 in the code-quality job to match all other jobs.

Validation

  • uv run ruff check . β€” All checks passed βœ…
  • uv run pyright β€” 0 errors βœ…

Warning

Protected Files β€” Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files
  • pyproject.toml

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually
# Download the patch from the workflow run
gh run download 24573958383 -n agent -D /tmp/agent-24573958383

# Create a new branch
git checkout -b repo-assist/testing-improvements-2026-04-17-5e55b8d05a9bf3ee master

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-24573958383/aw-repo-assist-testing-improvements-2026-04-17.patch

# Push the branch and create the pull request
git push origin repo-assist/testing-improvements-2026-04-17-5e55b8d05a9bf3ee
gh pr create --title '[Repo Assist] Fix ruff lint issues in test_scheduler; remove test_subject/test_scheduler from ruff exclude; standardise setup-python@v5' --base master --head repo-assist/testing-improvements-2026-04-17-5e55b8d05a9bf3ee --repo ReactiveX/RxPY

Note

πŸ”’ Integrity filter blocked 10 items

The following items were blocked because they don't meet the GitHub integrity level.

  • using timeout with GroupedObservable leads to an index shiftΒ #225 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Sort hot observable between (slow) scan executionsΒ #237 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Observable interval appears to leakΒ #259 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Example noteboks are out of dateΒ #265 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • Proposal for a subscribe schedulerΒ #309 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #749 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #748 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #742 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #736 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #711 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist Β· ● 3.1M Β· β—·

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions