Open
Description
Describe the bug
When sending a message to a WebSocketSubject that causes the serializer to throw an exception, rxjs throws instead a different exception:
TypeError: WebSocketSubject.error must be called with an object with an error code, and an optional reason: { code: number, reason: string }
at Object.eval [as error] (WebSocketSubject.js:156:26)
at ConsumerObserver.error (Subscriber.js:118:25)
at Subscriber._error (Subscriber.js:82:24)
at Subscriber.error (Subscriber.js:59:12)
at Object.eval [as next] (WebSocketSubject.js:145:31)
at ConsumerObserver.next (Subscriber.js:108:25)
at Subscriber._next (Subscriber.js:78:22)
at Subscriber.next (Subscriber.js:51:12)
at ReplaySubject._subscribe (ReplaySubject.js:55:18)
at Observable._trySubscribe (Observable.js:43:19)
at Subject._trySubscribe (Subject.js:117:43)
at eval (Observable.js:37:115)
at errorContext (errorContext.js:28:5)
at Observable.subscribe (Observable.js:35:47)
at socket.onopen [as _onopen] (WebSocketSubject.js:168:32)
Expected behavior
The original error should be thrown instead
Reproduction code
const socket$ = webSocket({
url: 'http://www.example.com/',
serializer: message => {
return JSON.stringify(message);
}
});
socket$.subscribe({
next: (v) => console.log('next', v),
error: e => console.error('caught', e),
complete: () => console.log('complete')
});
socket$.next({
value: BigInt(5)
});Reproduction URL
https://codesandbox.io/s/lively-river-dqm1qr?file=/src/index.ts:197-527
Version
7.5.7
Environment
No response
Additional context
This often creates hard-to-debug errors, as you can't know what was the original exception that happened in the serializer.
(The example code is trivial, but it's tough when the serialiser works with binary streams).