Skip to content

Commit 7640cb1

Browse files
chore: Configure Yarn to use node_modules linker and define packageManager, improve API base URL loading, and refine application feedback and toast handling.
1 parent 31dfffa commit 7640cb1

File tree

3 files changed

+9
-37
lines changed

3 files changed

+9
-37
lines changed

applications/script.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,15 @@ function updateUserApplication({ isAccepted, isRequestChanges = false }) {
130130
const payload = { status: applicationStatus };
131131

132132
const promises = [];
133+
const feedback =
134+
applicationTextarea && applicationTextarea.value
135+
? applicationTextarea.value.trim()
136+
: '';
133137

134-
if (applicationTextarea && applicationTextarea.value) {
138+
if (feedback) {
135139
promises.push(
136140
addApplicationFeedback(currentApplicationId, {
137-
feedback: applicationTextarea.value,
141+
feedback,
138142
status: applicationStatus,
139143
}),
140144
);
@@ -153,7 +157,7 @@ function updateUserApplication({ isAccepted, isRequestChanges = false }) {
153157
isDev,
154158
oldToastFunction: showToast,
155159
type: 'success',
156-
message: 'Application updated successfully!',
160+
message: 'application updated successfully!',
157161
});
158162
setTimeout(() => closeApplicationDetails(), 1000);
159163
})
@@ -737,5 +741,5 @@ applicationRejectButton.addEventListener('click', () =>
737741
updateUserApplication({ isAccepted: false }),
738742
);
739743
applicationRequestChangesButton.addEventListener('click', () => {
740-
updateUserApplication({ isAccepted: false, isRequestChanges: true });
744+
updateUserApplication({ isRequestChanges: true });
741745
});

applications/style.css

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -787,37 +787,6 @@ body {
787787
width: 18%;
788788
}
789789

790-
.application-details .application-details-actions .application-details-nudge {
791-
background-color: white;
792-
color: var(--color-primary);
793-
margin: 0 auto;
794-
width: 18%;
795-
border: 2px solid var(--color-primary);
796-
padding: 8px 16px;
797-
border-radius: 4px;
798-
}
799-
800-
.application-details
801-
.application-details-actions
802-
.application-details-nudge:is(:hover, :active, :focus-visible) {
803-
background: var(--color-primary);
804-
color: var(--white);
805-
transition: transform 0.2s ease;
806-
will-change: transform;
807-
}
808-
809-
.application-details
810-
.application-details-actions
811-
.application-details-nudge:hover {
812-
transform: scale(1.05);
813-
}
814-
815-
.application-details
816-
.application-details-actions
817-
.application-details-nudge:active {
818-
animation: bounceBackAnimation 0.4s ease forwards;
819-
}
820-
821790
.application-details
822791
.application-details-actions
823792
.application-details-request-changes {
@@ -851,7 +820,6 @@ body {
851820
padding: 15px;
852821
}
853822

854-
.application-details .application-details-actions .application-details-nudge,
855823
.application-details .application-details-actions .application-details-accept,
856824
.application-details .application-details-actions .application-details-reject,
857825
.application-details

components/toast/script.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function showToastMessage({ isDev, oldToastFunction, type, message }) {
5151
if (isDev) {
5252
createToast(type, message);
5353
} else if (oldToastFunction.length === 1) {
54-
oldToastFunction(message);
54+
oldToastFunction({ message, type });
5555
} else {
5656
oldToastFunction(type, message);
5757
}

0 commit comments

Comments
 (0)