Merge pull request #54 from Recidiviz/dan/fix-table-creation-metadata

Store Table `lastModifiedTime` / `creationTime` timestamps as Unix milliseconds

Author: ohaibbq

server/handler.go

@@ -3262,7 +3262,7 @@ type tablesInsertRequest struct {
 }
 
 func createTableMetadata(ctx context.Context, tx *connection.Tx, server *Server, project *metadata.Project, dataset *metadata.Dataset, table *bigqueryv2.Table) (*bigqueryv2.Table, *ServerError) {
-	now := time.Now().Unix()
+	now := time.Now().UnixMilli()
 	table.Id = fmt.Sprintf("%s:%s.%s", project.ID, dataset.ID, table.TableReference.TableId)
 	table.CreationTime = now
 	table.LastModifiedTime = uint64(now)

test/python/emulator_test.py

@@ -1123,3 +1123,35 @@ def test_time_min_max(self) -> None:
                 }
             ],
         )
+
+    def test_table_metadata_timestamp_format(self) -> None:
+        """Tests resolution of https://github.com/goccy/bigquery-emulator/issues/432
+
+        Table metadata timestamps (creationTime, lastModifiedTime) should be in
+        Unix milliseconds (13 digits), not Unix seconds (10 digits), to match
+        the real BigQuery API behavior.
+        """
+        address = BigQueryAddress(dataset_id=_DATASET_1, table_id=_TABLE_1)
+        self.create_mock_table(
+            address,
+            schema=[
+                bigquery.SchemaField(
+                    "a",
+                    field_type=bigquery.enums.SqlTypeNames.INTEGER.value,
+                    mode="REQUIRED",
+                ),
+            ],
+        )
+
+        # Get the table metadata
+        table = self.client.get_table(self._table_ref_for_address(address))
+
+        # Verify that created timestamp is set and in a reasonable range
+        self.assertIsNotNone(table.created)
+        self.assertIsNotNone(table.modified)
+
+        # The timestamps should be datetime objects that correspond to a recent time
+        # (not 1970 which would happen if milliseconds were interpreted as seconds)
+        now = datetime.datetime.now()
+        self.assertGreaterEqual(table.created.year, now.year)
+        self.assertGreaterEqual(table.modified.year, now.year)

types/types.go

@@ -37,7 +37,7 @@ func (t *Table) ToBigqueryV2(projectID, datasetID string) *bigqueryv2.Table {
 	for i, col := range t.Columns {
 		fields[i] = col.TableFieldSchema()
 	}
-	now := time.Now().Unix()
+	now := time.Now().UnixMilli()
 	return &bigqueryv2.Table{
 		Type: "TABLE",
 		Kind: "bigquery#table",