Merge pull request #28 from martinpovolny/manifest_upload

Implement upload of the manifest.

Author: mturley

app/controllers/api/red_hat_migration_analytics_controller.rb

@@ -5,6 +5,7 @@ def index
       manifest = self.class.parse_manifest
       res = {
         :manifest_version => manifest[:version],
+        :default_manifest_version => manifest[:default_version],
         :using_default_manifest => manifest[:using_default]
       }
       render_resource :red_hat_migration_analytics, res
@@ -32,6 +33,23 @@ def bundle_collection(type, data)
       action_result(false, e.to_s)
     end
 
+    def import_manifest_collection(type, data)
+      check_feature_enabled
+      self.class.store_manifest(data['manifest'])
+      action_result(true, 'imported manifest')
+    end
+
+    def reset_manifest_collection(type, data)
+      check_feature_enabled
+      path = self.class.user_manifest_path
+      if File.exist?(path)
+        File.unlink(path)
+        action_result(true, 'deleted manifest')
+      else
+        action_result(true, 'manifest does not exist')
+      end
+    end
+
     private
 
     def check_feature_enabled
@@ -46,18 +64,33 @@ def find_provider_ids(type)
     end
 
     class << self
-      def parse_manifest
-        default_manifest_path = Cfme::MigrationAnalytics::Engine.root.join("config", "default-manifest.json")
-        user_manifest_path    = Pathname.new("/opt/rh/cfme-migration_analytics/manifest.json")
-        manifest_path         = user_manifest_path.exist? ? user_manifest_path : default_manifest_path
 
-        manifest = Vmdb::Settings.filter_passwords!(load_manifest(manifest_path))
+      def default_manifest_path
+        @default_manifest_path ||= Cfme::MigrationAnalytics::Engine.root.join("config", "default-manifest.json")
+      end
+
+      def user_manifest_path
+        @user_manifest_path ||= Pathname.new("/opt/rh/cfme-migration_analytics/manifest.json")
+      end
 
+      def store_manifest(manifest)
+        user_manifest_path.write(JSON.generate(manifest))
+      end
+
+      def parse_manifest
+        default_manifest = Vmdb::Settings.filter_passwords!(load_manifest(default_manifest_path))
+        using_default = !user_manifest_path.exist?
+        manifest = if using_default
+                     default_manifest
+                   else
+                     Vmdb::Settings.filter_passwords!(load_manifest(user_manifest_path))
+                   end
         {
-          :path          => manifest_path,
-          :body          => manifest,
-          :version       => manifest.dig("manifest", "version"),
-          :using_default => manifest_path == default_manifest_path
+          :path            => using_default ? default_manifest : user_manifest_path,
+          :body            => manifest,
+          :version         => manifest.dig("manifest", "version"),
+          :default_version => default_manifest.dig("manifest", "version"),
+          :using_default   => using_default
         }
       end
 

config/api.yml

@@ -14,4 +14,9 @@
         :identifier: red_hat_migration_analytics
       :post:
       - :name: bundle
-        :identifier: red_hat_migration_analytics
+        :identifier: red_hat_migration_analytics
+      - :name: import_manifest
+        :identifier: red_hat_migration_analytics
+      - :name: reset_manifest
+        :identifier: red_hat_migration_analytics
+

spec/requests/red_hat_migration_analytics_spec.rb

@@ -12,6 +12,7 @@
       end
 
       it "with the built-in manifest" do
+        expect(Api::RedHatMigrationAnalyticsController).to receive(:user_manifest_path).and_return(Pathname.new('/non-existent-file'))
         get(api_red_hat_migration_analytics_url)
 
         expect(response).to have_http_status(:ok)
@@ -25,6 +26,7 @@
           "ssh_key_data"  => nil
         }
 
+        expect(Api::RedHatMigrationAnalyticsController).to receive(:user_manifest_path).and_return(Pathname.new('/non-existent-file'))
         expect(Api::RedHatMigrationAnalyticsController).to receive(:load_manifest).and_return(malicious_manifest)
 
         get(api_red_hat_migration_analytics_url)
@@ -58,5 +60,40 @@
       )
       expect(response).to have_http_status(:ok)
     end
+
+    it "/api/red_hat_migration_analytics/:id import_manifest action" do
+      api_basic_authorize "red_hat_migration_analytics"
+
+      expect(Api::RedHatMigrationAnalyticsController).to receive(:store_manifest)
+
+      post(api_red_hat_migration_analytics_url,
+           :params => {
+             "action"   => "import_manifest",
+             "manifest" => { "foo" => "bar "}
+      })
+
+      expect(response.parsed_body).to include(
+        "success" => true,
+        "message" => "imported manifest"
+      )
+      expect(response).to have_http_status(:ok)
+    end
+
+    it "/api/red_hat_migration_analytics/:id reset_manifest action" do
+      api_basic_authorize "red_hat_migration_analytics"
+
+      expect(Api::RedHatMigrationAnalyticsController).to receive(:user_manifest_path).and_return(Pathname.new('/non-existent-file'))
+
+      post(api_red_hat_migration_analytics_url,
+           :params => {
+             "action"       => "reset_manifest"
+      })
+
+      expect(response.parsed_body).to include(
+        "success" => true,
+        "message" => "manifest does not exist"
+      )
+      expect(response).to have_http_status(:ok)
+    end
   end
 end