withStatusContext breaks default pipeline behavior

[quarckster]

Current implementation dry method in withStatusContext breaks default pipeline behavior. The default behavior is to abort further execution of the pipeline if some stage failed. In job logs I can see hudson.AbortException: script returned exit code 1. This exception should abort further execution but it's caught instead. I believe it's incorrect behavior.

[bsquizz]

It's actually intended behavior so that if, for example, lint fails, then the unit tests or other tests will still run, so that you don't end up fixing lint problems to only discover now you have unit test problems :)

Perhaps we could add an optional flag to the function that aborts immediately if the caller desires?

[quarckster]

From my perspective default behavior should abort a stage in case any error. It's common for other CI services such as Travis, Gitlab CI and so on. If we introduce this optional flag it should bypass abortion.