Skip to content

Commit ca6a753

Browse files
authored
Fixes lint warnings (#588)
Refer: 1. ros-frontend/src/Components/InstanceTypes/SuggestedInstanceTypesTable.js 42:8 warning React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array - react-hooks/exhaustive-deps 2. ros-frontend/src/Routes/RosSuggestedInstanceTypes/RosSuggestedInstanceTypes.js 28:8 warning React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array - react-hooks/exhaustive-deps 65:8 warning React Hook useEffect has missing dependencies: 'hideGlobalFilter' and 'updateDocumentTitle'. Either include them or remove the dependency array - react-hooks/exhaustive-deps
1 parent 3475b19 commit ca6a753

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Components/InstanceTypes/SuggestedInstanceTypesTable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default function SuggestedInstanceTypesTable() {
3939
dispatch(loadSuggestedInstanceTypes({
4040
page, perPage, activeSortDirection, activeSortColumnKey, instanceTypeName
4141
}));
42-
}, [
42+
}, [dispatch,
4343
page,
4444
perPage,
4545
activeSortDirection,

src/Routes/RosSuggestedInstanceTypes/RosSuggestedInstanceTypes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const SuggestedInstance = () => {
2525

2626
useEffect(() => {
2727
dispatch(loadIsConfiguredInfo());
28-
}, []);
28+
}, [dispatch]);
2929

3030
return (
3131
showConfigSteps
@@ -62,7 +62,7 @@ export default function RosSuggestedInstanceTypes() {
6262
useEffect(() => {
6363
updateDocumentTitle('Suggested Instance Types - Resource Optimization - Business ');
6464
hideGlobalFilter();
65-
}, []);
65+
}, [updateDocumentTitle, hideGlobalFilter]);
6666

6767
return (
6868
hasPermissions

0 commit comments

Comments
 (0)