[Storage] replace artifactory with DataSource in test_golden_image (#4095)

##### Short description:
This PR replaces the use of the artifactory with the DataSource Fedora
in tests/storage/golden_image/test_golden_image.py
https://issues.redhat.com/browse/CNV-79290

##### More details:


##### What this PR does / why we need it:

##### Which issue(s) this PR fixes:

##### Special notes for reviewer:
There is another PR
#3892
that contains changes used by this PR:
- moving fedora_data_source_scope_module fixture from
tests/storage/cdi_clone/conftest.py to tests/storage/conftest.py
- adding a separate function get_dv_size_from_datasource to get the size
from a DataSource (the function is placed in tests/storage/utils.py
since it will be used both in
tests/storage/golden_image/test_golden_image.py and
tests/storage/restricted_namespace_cloning
(#3892))

##### jira-ticket:
<!-- full-ticket-url needs to be provided. This would add a link to the
pull request to the jira and close it when the pull request is merged
If the task is not tracked by a Jira ticket, just write "NONE".
-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Tests**
* Updated storage tests to use dynamic data sources instead of hardcoded
image URLs and sizes.
* Added support for Fedora OS flavor in test fixtures alongside existing
RHEL configurations.
* Refactored golden image tests to use data source references for
DataVolume creation, providing more flexible and maintainable test
scenarios.
* Improved test utility functions to support dynamic size extraction
from data sources.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: kshvaika

tests/storage/cdi_clone/conftest.py

@@ -1,9 +1,7 @@
 import pytest
-from ocp_resources.data_source import DataSource
 from ocp_resources.datavolume import DataVolume
 
 from tests.storage.utils import create_cirros_dv
-from utilities.constants import OS_FLAVOR_FEDORA
 from utilities.storage import data_volume
 
 
@@ -50,13 +48,3 @@ def data_volume_snapshot_capable_storage_scope_function(
         storage_class_matrix=storage_class_matrix_snapshot_matrix__function__,
         client=namespace.client,
     )
-
-
-@pytest.fixture(scope="module")
-def fedora_data_source_scope_module(golden_images_namespace):
-    return DataSource(
-        namespace=golden_images_namespace.name,
-        name=OS_FLAVOR_FEDORA,
-        client=golden_images_namespace.client,
-        ensure_exists=True,
-    )

tests/storage/conftest.py

@@ -51,6 +51,7 @@
     CDI_OPERATOR,
     CDI_UPLOADPROXY,
     CNV_TEST_SERVICE_ACCOUNT,
+    OS_FLAVOR_FEDORA,
     OS_FLAVOR_RHEL,
     RHEL10_PREFERENCE,
     SECURITY_CONTEXT,
@@ -583,6 +584,16 @@ def rhel10_data_source_scope_module(golden_images_namespace):
     )
 
 
+@pytest.fixture(scope="module")
+def fedora_data_source_scope_module(golden_images_namespace):
+    return DataSource(
+        namespace=golden_images_namespace.name,
+        name=OS_FLAVOR_FEDORA,
+        client=golden_images_namespace.client,
+        ensure_exists=True,
+    )
+
+
 @pytest.fixture(scope="class")
 def unique_suffix():
     return shortuuid.ShortUUID().random(length=4).lower()

tests/storage/golden_image/test_golden_image.py

@@ -7,7 +7,7 @@
 from pytest_testconfig import config as py_config
 
 from tests.os_params import RHEL_LATEST
-from utilities.artifactory import get_test_artifact_server_url
+from tests.storage.utils import get_dv_size_from_datasource
 from utilities.constants import PVC, TIMEOUT_20MIN
 from utilities.storage import ErrorMsg, create_dv
 
@@ -34,14 +34,20 @@ def dv_created_by_unprivileged_user_with_rolebinding(
     golden_images_edit_rolebinding,
     unprivileged_client,
     storage_class_name_scope_function,
+    fedora_data_source_scope_module,
 ):
+    size = get_dv_size_from_datasource(data_source=fedora_data_source_scope_module)
     with create_dv(
         client=unprivileged_client,
         dv_name=f"{request.param['dv_name']}-{storage_class_name_scope_function}",
         namespace=golden_images_namespace.name,
-        url=f"{get_test_artifact_server_url()}{LATEST_RHEL_IMAGE}",
-        size=RHEL_IMAGE_SIZE,
+        size=size,
         storage_class=storage_class_name_scope_function,
+        source_ref={
+            "kind": fedora_data_source_scope_module.kind,
+            "name": fedora_data_source_scope_module.name,
+            "namespace": fedora_data_source_scope_module.namespace,
+        },
     ) as dv:
         yield dv
 
@@ -52,19 +58,25 @@ def dv_created_by_unprivileged_user_with_rolebinding(
 def test_regular_user_cant_create_dv_in_ns(
     golden_images_namespace,
     unprivileged_client,
+    fedora_data_source_scope_module,
 ):
     LOGGER.info("Try as a regular user, to create a DV in golden image NS and receive the proper error")
+    size = get_dv_size_from_datasource(data_source=fedora_data_source_scope_module)
     with pytest.raises(
         ApiException,
         match=ErrorMsg.CANNOT_CREATE_RESOURCE,
     ):
         with create_dv(
             dv_name="cnv-4755",
             namespace=golden_images_namespace.name,
-            url=f"{get_test_artifact_server_url()}{LATEST_RHEL_IMAGE}",
-            size=RHEL_IMAGE_SIZE,
+            size=size,
             storage_class=py_config["default_storage_class"],
             client=unprivileged_client,
+            source_ref={
+                "kind": fedora_data_source_scope_module.kind,
+                "name": fedora_data_source_scope_module.name,
+                "namespace": fedora_data_source_scope_module.namespace,
+            },
         ):
             return
 

tests/storage/utils.py

@@ -10,6 +10,7 @@
 from ocp_resources.cluster_role import ClusterRole
 from ocp_resources.config_map import ConfigMap
 from ocp_resources.daemonset import DaemonSet
+from ocp_resources.data_source import DataSource
 from ocp_resources.datavolume import DataVolume
 from ocp_resources.hostpath_provisioner import HostPathProvisioner
 from ocp_resources.pod import Pod
@@ -503,3 +504,12 @@ def assert_disk_bus(vm: VirtualMachineForTests, volume: DataVolume, expected_bus
     assert disk is not None, f"Disk {volume.name} not found in VM {vm.name}"
     actual_bus = disk.get("disk", {}).get("bus")
     assert actual_bus == expected_bus, f"Disk {volume.name} has bus '{actual_bus}' but expected '{expected_bus}'"
+
+
+def get_dv_size_from_datasource(data_source: DataSource) -> str | int | None:
+    source_dict = data_source.source.instance.to_dict()
+    source_spec_dict = source_dict["spec"]
+    dv_size = source_spec_dict.get("resources", {}).get("requests", {}).get("storage") or source_dict.get(
+        "status", {}
+    ).get("restoreSize")
+    return dv_size