Skip to content

Commit 3ced153

Browse files
committed
Add initial Redfish unit tests
Added unit tests for Redfish system. These unit tests employ `unittest.mock`, which is a Python 3 feature only.
1 parent 0deaddc commit 3ced153

2 files changed

Lines changed: 154 additions & 1 deletion

File tree

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ python-novaclient==7.1.2
2626
python-heatclient
2727
pyvcloud==19.1.2
2828
py3winrm==0.0.1
29-
redfish-client==0.1.0
29+
redfish-client==0.2.1
3030
requests
3131
six
3232
tzlocal

tests/test_redfish.py

Lines changed: 153 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,153 @@
1+
# coding: utf-8
2+
# Unit tests for the Redfish API
3+
from unittest import mock, TestCase
4+
5+
from wrapanapi.exceptions import InvalidValueException
6+
from wrapanapi.systems import RedfishSystem
7+
from wrapanapi.systems.redfish import RedfishChassis, RedfishRack, RedfishServer
8+
9+
10+
@mock.patch("redfish_client.connect")
11+
class TestRedfishSystemSetup:
12+
def test_connect_non_ssl(self, mock_connector):
13+
RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
14+
mock_connector.assert_called_with("http://dummy:8000/", "user", "pass")
15+
16+
def test_connect_ssl(self, mock_connector):
17+
RedfishSystem("dummy", "user", "pass", "SSL", "443")
18+
mock_connector.assert_called_with("https://dummy:443/", "user", "pass")
19+
20+
21+
@mock.patch("redfish_client.Root.login")
22+
@mock.patch("redfish_client.CachingConnector")
23+
class TestRedfishSystem(TestCase):
24+
def test_find_resource(self, mock_connector, mock_root_login):
25+
mock_connector.return_value.get.return_value.status = 200
26+
mock_connector.return_value.get.return_value.json = {
27+
"@odata.id": "id"
28+
}
29+
30+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
31+
resource = rf.find("/redfish/v1/BlankResource")
32+
self.assertEqual(resource.raw, {"@odata.id": "id"})
33+
34+
def test_get_server(self, mock_connector, mock_root_login):
35+
mock_connector.return_value.get.return_value.status = 200
36+
mock_connector.return_value.get.return_value.json = {
37+
"@odata.id": "/redfish/v1/Systems/System-1-2-1-1",
38+
}
39+
40+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
41+
rf_server = rf.get_server("/redfish/v1/Systems/System-1-2-1-1")
42+
self.assertEqual(type(rf_server), RedfishServer)
43+
44+
def test_server_simple_properties(self, mock_connector, mock_root_login):
45+
mock_connector.return_value.get.return_value.status = 200
46+
mock_connector.return_value.get.return_value.json = {
47+
"@odata.id": "/redfish/v1/Systems/System-1-2-1-1",
48+
"Description": "A server",
49+
"Id": "System-1-2-1-1",
50+
"Manufacturer": "Dell Inc.",
51+
"Name": "System",
52+
"PowerState": "On",
53+
"SerialNumber": "945hjf0927mf",
54+
}
55+
56+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
57+
rf_server = rf.get_server("/redfish/v1/Systems/System-1-2-1-1")
58+
self.assertEqual(rf_server.name, "Dell Inc. System (945hjf0927mf)")
59+
self.assertEqual(rf_server.description, "A server")
60+
self.assertEqual(rf_server.state, "On")
61+
self.assertEqual(rf_server._identifying_attrs,
62+
{"odata_id": "/redfish/v1/Systems/System-1-2-1-1"})
63+
self.assertEqual(rf_server.uuid(), "System-1-2-1-1")
64+
65+
def test_server_name_no_sn(self, mock_connector, mock_root_login):
66+
mock_connector.return_value.get.return_value.status = 200
67+
mock_connector.return_value.get.return_value.json = {
68+
"@odata.id": "/redfish/v1/Systems/System-1-2-1-1",
69+
"Id": "System-1-2-1-1",
70+
"Manufacturer": "Dell Inc.",
71+
"Name": "System",
72+
}
73+
74+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
75+
rf_server = rf.get_server("/redfish/v1/Systems/System-1-2-1-1")
76+
self.assertEqual(rf_server.name, "Dell Inc. System")
77+
78+
def test_get_chassis(self, mock_connector, mock_root_login):
79+
mock_connector.return_value.get.return_value.status = 200
80+
mock_connector.return_value.get.return_value.json = {
81+
"@odata.id": "/redfish/v1/Chassis/Sled-1-2-1",
82+
}
83+
84+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
85+
rf_chassis = rf.get_chassis("/redfish/v1/Chassis/Sled-1-2-1")
86+
self.assertEqual(type(rf_chassis), RedfishChassis)
87+
88+
def test_get_chassis_simple_properties(self, mock_connector, mock_root_login):
89+
mock_connector.return_value.get.return_value.status = 200
90+
mock_connector.return_value.get.return_value.json = {
91+
"@odata.id": "/redfish/v1/Chassis/Sled-1-2-1",
92+
"ChassisType": "Sled",
93+
"Description": "G5 Sled-Level Enclosure",
94+
"Id": "Sled-1-2-1",
95+
"IndicatorLED": "Blinking",
96+
"Manufacturer": "Dell",
97+
"Name": "G5_Sled",
98+
"SerialNumber": "5555A",
99+
}
100+
101+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
102+
rf_chassis = rf.get_chassis("/redfish/v1/Chassis/Sled-1-2-1")
103+
self.assertEqual(rf_chassis.chassis_type, "Sled")
104+
self.assertEqual(rf_chassis.name, "Dell G5_Sled (5555A)")
105+
self.assertEqual(rf_chassis.description, "G5 Sled-Level Enclosure")
106+
self.assertEqual(rf_chassis.led_state, "Blinking")
107+
self.assertEqual(rf_chassis._identifying_attrs,
108+
{"odata_id": "/redfish/v1/Chassis/Sled-1-2-1"})
109+
self.assertEqual(rf_chassis.uuid(), "Sled-1-2-1")
110+
111+
def test_get_rack(self, mock_connector, mock_root_login):
112+
mock_connector.return_value.get.return_value.status = 200
113+
mock_connector.return_value.get.return_value.json = {
114+
"@odata.id": "/redfish/v1/Chassis/Rack-1",
115+
"ChassisType": "Rack",
116+
}
117+
118+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
119+
rf_rack = rf.get_rack("/redfish/v1/Chassis/Rack-1")
120+
self.assertEqual(type(rf_rack), RedfishRack)
121+
122+
def test_get_rack_bad(self, mock_connector, mock_root_login):
123+
mock_connector.return_value.get.return_value.status = 200
124+
mock_connector.return_value.get.return_value.json = {
125+
"@odata.id": "/redfish/v1/Chassis/Sled-1-2-1",
126+
"ChassisType": "Sled",
127+
}
128+
129+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
130+
with self.assertRaises(InvalidValueException,
131+
msg="Chassis type Sled does not match that of a Rack"):
132+
rf.get_rack("/redfish/v1/Chassis/Sled-1-2-1")
133+
134+
def test_get_rack_simple_properties(self, mock_connector, mock_root_login):
135+
mock_connector.return_value.get.return_value.status = 200
136+
mock_connector.return_value.get.return_value.json = {
137+
"@odata.id": "/redfish/v1/Chassis/Rack-1",
138+
"ChassisType": "Rack",
139+
"Description": "Redfish Rack",
140+
"Id": "Rack-1",
141+
"Manufacturer": "Dell",
142+
"Name": "G5_Rack",
143+
"SerialNumber": "1ABC",
144+
}
145+
146+
rf = RedfishSystem("dummy", "user", "pass", "Non-SSL", "8000")
147+
rf_rack = rf.get_rack("/redfish/v1/Chassis/Rack-1")
148+
self.assertEqual(rf_rack.chassis_type, "Rack")
149+
self.assertEqual(rf_rack.name, "Rack-1")
150+
self.assertEqual(rf_rack.description, "Redfish Rack")
151+
self.assertEqual(rf_rack.uuid(), "Rack-1")
152+
self.assertEqual(rf_rack._identifying_attrs, {"odata_id":
153+
"/redfish/v1/Chassis/Rack-1"})

0 commit comments

Comments
 (0)