Skip to content

Commit e06a95e

Browse files
authored
Merge pull request #246 from bsquizz/update_reqs
[1LP][RFR] Remove need to pin python-novaclient with s/HTTPClient/SessionClient
2 parents aa4bbda + c8d88fb commit e06a95e

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

requirements.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
six
2-
boto
32
cached_property
43
enum34
54
fauxfactory>=2.0.7
@@ -11,20 +10,17 @@ pyvmomi>=6.5.0.2017.5.post1
1110
python-cinderclient
1211
python-ironicclient
1312
python-keystoneclient
14-
python-novaclient<7.0.0
13+
python-novaclient==7.1.2
1514
python-heatclient
1615
pywinrm
1716
requests
18-
19-
20-
21-
2217
tzlocal
2318
wait_for
2419
websocket_client
2520
dateparser
2621
boto3==1.6.6
2722
botocore==1.9.6
23+
boto
2824
packaging
2925
azure>=3.0.0
3026
azure-storage-common>=1.0

wrapanapi/openstack.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ def api(self):
119119
timeout=30)
120120
# replace the client request method with our version that
121121
# can handle timeouts; uses explicit binding (versus
122-
# replacing the method directly on the HTTPClient class)
123-
# so we can still call out to HTTPClient's original request
122+
# replacing the method directly on the SessionClient class)
123+
# so we can still call out to SessionClient's original request
124124
# method in the timeout handler method
125125
self._api.client._cfme_logger = self.logger
126126
self._api.client.request = _request_timeout_handler.__get__(self._api.client,

wrapanapi/openstack_infra.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from ironicclient import client as iclient
55
from keystoneclient.v2_0 import client as oskclient
66
from novaclient import client as osclient
7-
from novaclient.client import HTTPClient
7+
from novaclient.client import SessionClient
88
from requests.exceptions import Timeout
99

1010
from .base import WrapanapiAPIBaseVM
@@ -24,7 +24,7 @@
2424
def _request_timeout_handler(self, url, method, retry_count=0, **kwargs):
2525
try:
2626
# Use the original request method to do the actual work
27-
return HTTPClient.request(self, url, method, **kwargs)
27+
return SessionClient.request(self, url, method, **kwargs)
2828
except Timeout:
2929
if retry_count >= 3:
3030
self._cfme_logger.error('nova request timed out after {} retries'.format(retry_count))
@@ -79,12 +79,12 @@ def api(self):
7979
timeout=30)
8080
# replace the client request method with our version that
8181
# can handle timeouts; uses explicit binding (versus
82-
# replacing the method directly on the HTTPClient class)
83-
# so we can still call out to HTTPClient's original request
82+
# replacing the method directly on the SessionClient class)
83+
# so we can still call out to SessionClient's original request
8484
# method in the timeout handler method
8585
self._api.client._cfme_logger = self.logger
8686
self._api.client.request = _request_timeout_handler.__get__(self._api.client,
87-
HTTPClient)
87+
SessionClient)
8888
return self._api
8989

9090
@property

0 commit comments

Comments
 (0)