fix(a11y): resolve accessibility issues in JsonViewer, SearchBox, and SelectOnClick#2800
Open
ApurveKaranwal wants to merge 1 commit into
Open
fix(a11y): resolve accessibility issues in JsonViewer, SearchBox, and SelectOnClick#2800ApurveKaranwal wants to merge 1 commit into
ApurveKaranwal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
aria-expandedand descriptivearia-labelattributes. Handledkeydown(Enter) triggers insideJsonViewer.tsxand calledevent.preventDefault()to prevent duplicate execution from the browser's synthetic click on<button>elements. Wrapped handlers inReact.useCallbackto satisfy ESLint warnings.tabIndex={0},role="button", andaria-label="Clear search"to the clear search icon, alongside anonKeyDownhandler listening forEnter/Space. Annotated search result box withrole="menu", an dynamic results-foundaria-label, andaria-live="polite"for the empty-results state.tabIndex={0},role="button", andaria-label="Select all text", enabling keyboard activation viaEnterorSpace.README.mdto help developers easily diagnose rendering or search issues.Reference
Resolves accessibility gaps (WCAG 2.1 AA) in interactive components.
Tests
src/components/__tests__/JsonViewer.tsxto verify:aria-expandedandaria-labelvalues.Entercorrectly toggles the state of collapsers.npm run unit).##Fixes #2799
Screenshots (optional)
N/A (semantic markup changes)
Check yourself