Merge pull request #37 from Refraggerator/fix/visual-tests-and-bug-verification

Fix DM handling, improve message persistence, and stabilize tests

Author: Refraggerator

ARCHITECTURE.md

@@ -159,10 +159,16 @@ Flutter App          Go AS              Synapse
     |                  |                   |
     |-- POST /guilds ->|                   |
     |                  |-- createRoom(space) --> |
+    |                  |-- createRoom(general, voice) with power_level_content_override --> |
     |                  |<- room_id ---------|
     |<- guild data ----|                   |
 ```
 
+**Child Room Power Levels:** The `general` and `voice` child rooms are created with a `power_level_content_override` that sets `users_default: 100` and `state_default: 0`. This ensures:
+- Every guild member (PL 0 by default after joining via invite) can send messages, set `m.call.member` state for voice, and create new channels.
+- `m.room.encrypted: 100` prevents accidental E2EE enablement in guild rooms.
+- The guild owner's Matrix user ID is set to PL 100 explicitly.
+
 ---
 
 ## 4. Development Workflow
@@ -223,7 +229,7 @@ cd app; dart analyze lib
 
 ### Unit & Widget Tests
 
-290 tests covering all providers, models, and key widgets.
+296 tests covering all providers, models, and key widgets (including 4 new chat-provider tests for message-history-on-re-login and 2 multi-user voice integration tests).
 
 **Location:** `app/test/`
 
@@ -241,25 +247,27 @@ cd app; dart analyze lib
 | Settings | `settings_provider_test.dart` | Audio settings persistence |
 | User Model | `user_test.dart` | String ID model, fromMatrixProfile, copyWith |
 | DMs | `dm_provider_test.dart` | DM list, DmRoom model, sort, create |
+| Chat | `chat_provider_test.dart` | Message history on re-login (requestHistory when cache empty), empty-channel guards |
 | Others | `center_view_provider_test.dart`, `image_processing_service_test.dart`, etc. | View mode, image processing |
 
 ```powershell
 cd app
-flutter test --reporter compact           # All 290 unit/widget tests
+flutter test --reporter compact           # All 296 unit/widget tests
 ```
 
 ### API Integration Tests
 
-28 tests across 6 groups, running against the live Docker stack.
+29 tests across 6 groups, running against the live Docker stack.
 These exercise the Matrix SDK and Go AS HTTP endpoints directly (no Flutter UI).
+Messaging tests (Group 3) use the CS API `PUT /rooms/{id}/send` directly to avoid SDK sync timeout issues.
 
 **Location:** `app/test/integration/matrix_api_test.dart`
 
 | Group | Tests | What it covers |
 |-------|-------|----------------|
 | 1 · Authentication | 5 | SDK login, wrong-password rejection, login flows, API versions |
 | 2 · Guild Management | 8 | Space + rooms creation, child state events, history_visibility, invite code, join + verify child rooms |
-| 3 · Messaging | 5 | Send/receive via CS API, cross-user read, message count |
+| 3 · Messaging | 5 | Send/receive via CS API (both users), cross-user read with retry for eventual consistency, message count |
 | 4 · Voice | 3 | LiveKit token generation for both users, URL validation |
 | 5 · AS Endpoints | 4 | Health, 401 on no auth, 401 on invalid token, 403 on txn |
 | 6 · Media & Config | 3 | mxc:// upload, registration status, presence |
@@ -356,6 +364,7 @@ flutter test integration_test/visual_test.dart -d windows
 ### Presence
 
 - **Source:** Native Matrix presence events via `client.onPresenceChanged.stream`.
+- **Eager Initialization:** `presenceProvider` is watched in `ConcordApp.build()` (alongside `autoStatusProvider`) so the subscription starts before the first Matrix sync completes. This prevents presence events arriving during the initial sync from being missed due to lazy Riverpod provider initialization.
 - **Mapping:** `PresenceType.online` → "online", `PresenceType.unavailable` →
   "away", `PresenceType.offline` → removed from map.
 - **Avatar/Name Resolution:** Display name and avatar URL resolved from room

FEATURES.md

@@ -11,9 +11,9 @@ Architecture: **Matrix-native** (Synapse homeserver + Go Application Service + F
 - [x] **Application Service (Go):** Fiber v2 AS for guild invites + LiveKit voice tokens
 - [x] **Flutter Matrix SDK:** `matrix: ^0.32.4` — native Client-Server API for all messaging, presence, rooms
 - [x] **Riverpod 3.x State Management:** NotifierProvider throughout (StateProvider removed)
-- [x] **Tests:** 290 unit/widget tests + 28 API integration tests + 34 visual UI integration tests (all passing)
+- [x] **Tests:** 331 unit/widget/integration tests (all passing) — 4 new chat-provider tests + 2 multi-user voice integration tests
 - [x] **Visual Integration Tests:** 34 end-to-end UI tests across 9 groups (E2EE, Server Selection, Registration, Login, Guilds, Invites, Channels, Messaging, Settings)
-- [x] **API Integration Tests:** 28 Matrix SDK + Go AS endpoint tests across 6 groups
+- [x] **API Integration Tests:** 29 Matrix SDK + Go AS endpoint tests across 6 groups (messaging tests use CS API directly for reliability)
 - [x] **In-App Logging:** LoggerService for structured app-level logging
 - [x] **MatrixSdkDatabase Migration:** Migrated from deprecated HiveCollectionsDatabase to SQLite-backed MatrixSdkDatabase with automatic legacy data migration
 - [x] **AS Security Hardening:** Timing-safe HS token comparison (`crypto/subtle`), error detail leak removal, mandatory config validation at startup, error logging for guild operations
@@ -41,14 +41,16 @@ Architecture: **Matrix-native** (Synapse homeserver + Go Application Service + F
 - [x] **Leave Guild:** `room.leave()` via Matrix SDK
 - [x] **Invite System:** AS generates 6-char codes; `POST /invites/:code` joins space + all child rooms
 - [x] **Message Persistence:** `history_visibility: shared` on all rooms (no E2EE on guild rooms) so messages survive logout/login
+- [x] **Message History on Re-login:** `requestHistory(historyCount: 50)` called automatically when local SQLite cache is empty after re-login — general channel messages are never lost
 - [x] **Owner Detection:** Extracted from `m.room.create` state event `senderId`
+- [x] **Child Room Power Levels:** All guild child rooms (general, voice) created with `users_default: 100` and `state_default: 0` so every member can send messages, set `m.call.member` state, and create new channels without needing admin rights
 
 ### Channels (Matrix Rooms)
 - [x] **Channel List:** Text and voice rooms as space children
 - [x] **Create Channel:** Matrix room creation + `m.space.child` state event; default power levels allow all members to create channels
 - [x] **Delete Channel:** `room.leave()` via Matrix SDK
 - [x] **Channel Types:** Text and voice differentiation
-- [x] **Channels Visible After Join:** Invite-join flow auto-joins child rooms; channels appear immediately
+- [x] **Channels Visible After Join:** Invite-join flow auto-joins child rooms; channels appear immediately for newly joined members (power levels allow all members to read and interact)
 
 ### Chat (Matrix Timeline)
 - [x] **Real-time Messaging:** Matrix sync / timeline stream for instant delivery
@@ -68,6 +70,7 @@ Architecture: **Matrix-native** (Synapse homeserver + Go Application Service + F
 
 ### Presence (Matrix-native)
 - [x] **Online/Away/Offline:** `client.onPresenceChanged.stream` → `PresenceNotifier`
+- [x] **Eager Initialization:** `presenceProvider` is eagerly started in `ConcordApp.build()` alongside `autoStatusProvider` so no presence events from the initial Matrix sync are missed
 - [x] **Auto-Away (Desktop):** 5-minute idle timer (mouse/keyboard inactivity)
 - [x] **Auto-Away (Mobile):** 30-second background grace period
 - [x] **Status Indicator:** Always visible in user controls
@@ -78,6 +81,7 @@ Architecture: **Matrix-native** (Synapse homeserver + Go Application Service + F
 - [x] **Connect/Disconnect:** Join/leave voice rooms via LiveKit + Matrix state events
 - [x] **m.call.member State:** Voice membership tracked via Matrix state events with `expires_ts`
 - [x] **VoiceStateStoreNotifier:** Parses `m.call.member` from all rooms on each sync
+- [x] **Multi-User Voice Visibility:** Both users' `m.call.member` state events are correctly visible to one another — tested via integration tests (sequential and simultaneous join scenarios)
 - [x] **Mute/Deafen Toggles:** Local track control + `broadcastVoiceStateChange()` state update
 - [x] **Single-Channel Enforcement:** Client-side invariant via `VoiceController` + `_broadcastLeave()` for old channel on switch
 - [x] **Voice Cleanup on Logout:** `leaveChannel()` called before `client.logout()` to clear `m.call.member` state