test(react-debug): cover source detection boundaries

Author: Rel1cx

plugins/eslint-plugin-react-debug/src/rules/is-from-react/is-from-react.spec.ts

@@ -4,6 +4,15 @@ import { ruleTester } from "#/testing/helpers";
 import { stringify } from "@/utils/stringify";
 import rule, { RULE_NAME } from "./is-from-react";
 
+function reactError(name: string, importSource = "react") {
+  return {
+    data: {
+      json: stringify({ name, importSource }),
+    },
+    messageId: "default" as const,
+  };
+}
+
 ruleTester.run(RULE_NAME, rule, {
   invalid: [
     {
@@ -633,6 +642,95 @@ ruleTester.run(RULE_NAME, rule, {
         },
       },
     },
+    {
+      code: tsx`
+        import ReactDOM from "react-dom";
+      `,
+      errors: [reactError("ReactDOM")],
+    },
+    {
+      code: tsx`
+        import type { ReactNode } from "react";
+
+        type Props = { children: ReactNode };
+      `,
+      errors: [
+        reactError("ReactNode"),
+        reactError("ReactNode"),
+      ],
+    },
+    {
+      code: tsx`
+        import * as React from "react";
+
+        const { Children: ReactChildren } = React;
+      `,
+      errors: [
+        reactError("React"),
+        reactError("ReactChildren"),
+        reactError("React"),
+      ],
+    },
+    {
+      code: tsx`
+        import React from "react";
+
+        const Children = React["Children"];
+      `,
+      errors: [
+        reactError("React"),
+        reactError("Children"),
+        reactError("React"),
+      ],
+    },
+    {
+      code: tsx`
+        import React from "react";
+
+        const only = React.Children.only;
+      `,
+      errors: [
+        reactError("React"),
+        reactError("React"),
+        reactError("Children"),
+      ],
+    },
+    {
+      code: tsx`
+        import { Component } from "react";
+
+        let Alias;
+        Alias = Component;
+        const Copy = Alias;
+      `,
+      errors: [
+        reactError("Component"),
+        reactError("Component"),
+      ],
+    },
+    {
+      code: tsx`
+        const React = {};
+        React.Children;
+      `,
+      errors: [
+        reactError("React"),
+        reactError("React"),
+        reactError("Children"),
+      ],
+    },
+    {
+      code: tsx`
+        import { memo } from "react";
+
+        const wrapped = memo as unknown;
+      `,
+      errors: [
+        reactError("memo"),
+        reactError("wrapped"),
+        reactError("memo"),
+      ],
+    },
   ],
   valid: [
     {
@@ -707,5 +805,16 @@ ruleTester.run(RULE_NAME, rule, {
         },
       },
     },
+    tsx`
+      export { memo } from "react";
+    `,
+    tsx`
+      const library = require(source);
+      const Children = library.Children;
+    `,
+    tsx`
+      const Reactish = {};
+      const value = Reactish.Children;
+    `,
   ],
 });

plugins/eslint-plugin-react-debug/src/rules/is-from-ref/is-from-ref.spec.ts

@@ -4,6 +4,15 @@ import { ruleTester } from "#/testing/helpers";
 import { stringify } from "@/utils/stringify";
 import rule, { RULE_NAME } from "./is-from-ref";
 
+function refError(name: string, init: string) {
+  return {
+    data: {
+      json: stringify({ name, init }),
+    },
+    messageId: "default" as const,
+  };
+}
+
 ruleTester.run(RULE_NAME, rule, {
   invalid: [
     {
@@ -17,51 +26,72 @@ ruleTester.run(RULE_NAME, rule, {
         }
       `,
       errors: [
-        {
-          data: {
-            json: stringify({
-              name: "myRef",
-              init: "React.useRef(42)",
-            }),
-          },
-          messageId: "default",
-        },
-        {
-          data: {
-            json: stringify({
-              name: "value",
-              init: "myRef.current",
-            }),
-          },
-          messageId: "default",
-        },
-        {
-          data: {
-            json: stringify({
-              name: "myRef",
-              init: "React.useRef(42)",
-            }),
-          },
-          messageId: "default",
-        },
-        {
-          data: {
-            json: stringify({
-              name: "current",
-              init: "React.useRef(42)",
-            }),
-          },
-          messageId: "default",
-        },
-        {
-          data: {
-            json: stringify({
-              name: "value",
-              init: "myRef.current",
-            }),
-          },
-          messageId: "default",
-        },
+        refError("myRef", "React.useRef(42)"),
+        refError("value", "myRef.current"),
+        refError("myRef", "React.useRef(42)"),
+        refError("current", "React.useRef(42)"),
+        refError("value", "myRef.current"),
+      ],
+    },
+    {
+      code: tsx`
+        import { useRef } from "react";
+
+        const ref = useRef(null);
+      `,
+      errors: [refError("ref", "useRef(null)")],
+    },
+    {
+      code: tsx`
+        const ref = hooks.useRef(null);
+      `,
+      errors: [refError("ref", "hooks.useRef(null)")],
+    },
+    {
+      code: tsx`
+        function read(ref, inputRef) {
+          const first = ref.value;
+          const second = inputRef.value;
+        }
+      `,
+      errors: [
+        refError("first", "ref.value"),
+        refError("second", "inputRef.value"),
+      ],
+    },
+    {
+      code: tsx`
+        const sourceRef = useRef(null);
+        const alias = sourceRef;
+        const value = alias.current;
+      `,
+      errors: [
+        refError("sourceRef", "useRef(null)"),
+        refError("sourceRef", "useRef(null)"),
+      ],
+    },
+    {
+      code: tsx`
+        const myRef = useRef(null);
+
+        function read() {
+          const myRef = { current: 0 };
+          return myRef.current;
+        }
+      `,
+      errors: [refError("myRef", "useRef(null)")],
+    },
+    {
+      code: tsx`
+        import React from "react";
+
+        const ComponentRef = React.useRef(() => null);
+        const element = <ComponentRef.current />;
+      `,
+      errors: [
+        refError("ComponentRef", "React.useRef(() => null)"),
+        refError("ComponentRef", "React.useRef(() => null)"),
+        refError("current", "React.useRef(() => null)"),
       ],
     },
   ],
@@ -75,5 +105,30 @@ ruleTester.run(RULE_NAME, rule, {
         return <div>{value}</div>;
       }
     `,
+    tsx`
+      import React from "react";
+
+      const createdRef = React.createRef();
+      const factory = React.useRef;
+      const similar = React.useRefValue();
+    `,
+    tsx`
+      function read(reference, myref, holder, inputRef) {
+        const fromReference = reference.current;
+        const fromLowercase = myref.current;
+        const fromNested = holder.inputRef.current;
+        const fromOptional = inputRef?.current;
+      }
+    `,
+    tsx`
+      function read(sourceRef) {
+        const alias = sourceRef;
+        const value = alias.current;
+      }
+    `,
+    tsx`
+      let ref;
+      ref = useRef(null);
+    `,
   ],
 });