Skip to content

Commit 1d14f23

Browse files
committed
Minor imports fixes
1 parent 6b8bac9 commit 1d14f23

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-direct-set-state-in-use-effect.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as ast from "@eslint-react/ast";
2-
import { isUseCallbackCall, isUseEffectLikeCall, isUseMemoCall, isUseStateLikeCall } from "@eslint-react/core";
2+
import * as core from "@eslint-react/core";
33
import { constVoid, getOrElseUpdate, not } from "@eslint-react/eff";
44
import { type RuleContext, type RuleFeature, getSettingsFromContext } from "@eslint-react/shared";
55
import { findVariable, getVariableDefinitionNode } from "@eslint-react/var";
@@ -83,13 +83,13 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
8383
}
8484

8585
function isUseStateCall(node: TSESTree.Node) {
86-
return isUseStateLikeCall(node, additionalStateHooks);
86+
return core.isUseStateLikeCall(node, additionalStateHooks);
8787
}
8888

8989
function isUseEffectSetupCallback(node: TSESTree.Node) {
9090
return node.parent?.type === AST.CallExpression
9191
&& node.parent.callee !== node
92-
&& isUseEffectLikeCall(node.parent);
92+
&& core.isUseEffectLikeCall(node.parent);
9393
}
9494

9595
function getCallName(node: TSESTree.Node) {
@@ -102,7 +102,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
102102
function getCallKind(node: TSESTree.CallExpression) {
103103
return match<TSESTree.CallExpression, CallKind>(node)
104104
.when(isUseStateCall, () => "useState")
105-
.when(isUseEffectLikeCall, () => "useEffect")
105+
.when(core.isUseEffectLikeCall, () => "useEffect")
106106
.when(isSetStateCall, () => "setState")
107107
.when(isThenCall, () => "then")
108108
.otherwise(() => "other");
@@ -258,7 +258,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
258258
// const [state, setState] = useState();
259259
// const set = useMemo(() => setState, []);
260260
// useEffect(set, []);
261-
if (!isUseMemoCall(parent)) {
261+
if (!core.isUseMemoCall(parent)) {
262262
break;
263263
}
264264
const init = ast.findParentNode(parent, isVariableDeclaratorFromHookCall)?.init;
@@ -274,7 +274,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
274274
// const [state, setState] = useState();
275275
// const set = useCallback(setState, []);
276276
// useEffect(set, []);
277-
if (isUseCallbackCall(node.parent)) {
277+
if (core.isUseCallbackCall(node.parent)) {
278278
const init = ast.findParentNode(node.parent, isVariableDeclaratorFromHookCall)?.init;
279279
if (init != null) {
280280
getOrElseUpdate(setStateInEffectArg, init, () => []).push(node);
@@ -283,7 +283,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
283283
}
284284
// const [state, setState] = useState();
285285
// useEffect(setState);
286-
if (isUseEffectLikeCall(node.parent)) {
286+
if (core.isUseEffectLikeCall(node.parent)) {
287287
getOrElseUpdate(setStateInEffectSetup, node.parent, () => []).push(node);
288288
}
289289
}

packages/plugins/eslint-plugin-react-x/src/rules/no-class-component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { isComponentDidCatch, isGetDerivedStateFromError, useComponentCollectorLegacy } from "@eslint-react/core";
1+
import * as core from "@eslint-react/core";
22
import { type RuleContext, type RuleFeature, defineRuleListener } from "@eslint-react/shared";
33
import type { RuleListener } from "@typescript-eslint/utils/ts-eslint";
44
import type { CamelCase } from "string-ts";
@@ -30,13 +30,13 @@ export default createRule<[], MessageID>({
3030
export function create(context: RuleContext<MessageID, []>): RuleListener {
3131
// Fast path: skip if `Component` is not present in the file
3232
if (!context.sourceCode.text.includes("Component")) return {};
33-
const { ctx, visitor } = useComponentCollectorLegacy(context);
33+
const { ctx, visitor } = core.useComponentCollectorLegacy(context);
3434
return defineRuleListener(
3535
visitor,
3636
{
3737
"Program:exit"(program) {
3838
for (const { name = "anonymous", node: component } of ctx.getAllComponents(program)) {
39-
if (component.body.body.some((m) => isComponentDidCatch(m) || isGetDerivedStateFromError(m))) {
39+
if (component.body.body.some((m) => core.isComponentDidCatch(m) || core.isGetDerivedStateFromError(m))) {
4040
continue;
4141
}
4242
context.report({

packages/plugins/eslint-plugin-react-x/src/rules/no-missing-component-display-name.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as ast from "@eslint-react/ast";
2-
import { ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, useComponentCollector } from "@eslint-react/core";
2+
import * as core from "@eslint-react/core";
33
import { type RuleContext, type RuleFeature, defineRuleListener } from "@eslint-react/shared";
44
import type { RuleListener } from "@typescript-eslint/utils/ts-eslint";
55
import type { CamelCase } from "string-ts";
@@ -32,9 +32,9 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
3232
// Fast path: skip if `memo` or `forwardRef` is not present in the file
3333
if (!context.sourceCode.text.includes("memo") && !context.sourceCode.text.includes("forwardRef")) return {};
3434

35-
const { ctx, visitor } = useComponentCollector(context, {
35+
const { ctx, visitor } = core.useComponentCollector(context, {
3636
collectDisplayName: true,
37-
hint: DEFAULT_COMPONENT_DETECTION_HINT,
37+
hint: core.DEFAULT_COMPONENT_DETECTION_HINT,
3838
});
3939

4040
return defineRuleListener(
@@ -44,7 +44,7 @@ export function create(context: RuleContext<MessageID, []>): RuleListener {
4444
for (const { node, displayName, flag } of ctx.getAllComponents(program)) {
4545
const id = ast.getFunctionId(node);
4646
// Check if the component is wrapped with `forwardRef` or `memo`
47-
const isMemoOrForwardRef = (flag & (ComponentFlag.ForwardRef | ComponentFlag.Memo)) > 0n;
47+
const isMemoOrForwardRef = (flag & (core.ComponentFlag.ForwardRef | core.ComponentFlag.Memo)) > 0n;
4848
// If the component is a named function, it has an implicit displayName
4949
if (id != null) {
5050
continue;

0 commit comments

Comments
 (0)