[WIP] WIP address feedback on renaming component detection hints (#1485)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Copilot

packages/core/src/component/component-detection-hint.ts

@@ -21,14 +21,14 @@ export const ComponentDetectionHint = {
  * Default component detection hint
  */
 export const DEFAULT_COMPONENT_DETECTION_HINT = 0n
-  | JsxDetectionHint.DoNotIncludeJsxWithNumberValue
   | ComponentDetectionHint.DoNotIncludeJsxWithBigIntValue
   | ComponentDetectionHint.DoNotIncludeJsxWithBooleanValue
+  | ComponentDetectionHint.DoNotIncludeJsxWithNumberValue
   | ComponentDetectionHint.DoNotIncludeJsxWithStringValue
   | ComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue
-  | ComponentDetectionHint.RequireAllArrayElementsToBeJsx
-  | ComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx
-  | ComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx
+  | ComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback
   | ComponentDetectionHint.DoNotIncludeFunctionDefinedInArrayExpression
   | ComponentDetectionHint.DoNotIncludeFunctionDefinedInArrayPattern
-  | ComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
+  | ComponentDetectionHint.RequireAllArrayElementsToBeJsx
+  | ComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx
+  | ComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx;

packages/core/src/jsx/jsx-detection.ts

@@ -109,15 +109,15 @@ export function isJsxLike(
       if (node.elements.length === 0) {
         return !(hint & JsxDetectionHint.DoNotIncludeJsxWithEmptyArrayValue);
       }
-      // StrictArray requires all elements to be JSX
+      // Requires all elements to be JSX
       if (hint & JsxDetectionHint.RequireAllArrayElementsToBeJsx) {
         return node.elements.every((n) => isJsxLike(code, n, hint));
       }
       // Default: array is JSX-like if any element is JSX-like
       return node.elements.some((n) => isJsxLike(code, n, hint));
     }
     case AST.LogicalExpression: {
-      // StrictLogical requires both sides to be JSX
+      // Requires both sides to be JSX
       if (hint & JsxDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx) {
         return isJsxLike(code, node.left, hint) && isJsxLike(code, node.right, hint);
       }
@@ -144,7 +144,7 @@ export function isJsxLike(
         return isJsxLike(code, node.alternate, hint);
       }
 
-      // StrictConditional requires both branches to contain JSX
+      // Requires both branches to contain JSX
       if (hint & JsxDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx) {
         return leftHasJSX(node) && rightHasJSX(node);
       }