Setup megalinter conf and fix files (#26)

* Setup megalinter conf and fix files

* Disable flake8

* cleanup readme

* Disable kics

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: RelativeSure <[email protected]>

Author: RelativeSure

.github/workflows/files-changed.yml

@@ -40,7 +40,7 @@ jobs:
         shell: bash
         env:
           WEBHOOK: ${{ secrets.WEBHOOK_URL }}
-        run: ./scripts/copr_webhook.sh $WEBHOOK ${{ github.sha }}
+        run: ./scripts/copr_webhook.sh "$WEBHOOK" "${{ github.sha }}"
 
   update-readme:
     runs-on: ubuntu-latest

.github/workflows/update.yml

@@ -1,10 +1,10 @@
 name: Update spec files
 on:
   workflow_dispatch:
-  
+
   schedule:
     # Runs at 12:00am UTC -> 5:00pm PDT
-    - cron: '0 0 * * *'
+    - cron: "0 0 * * *"
 
 permissions:
   # Needs to write to this repo
@@ -14,15 +14,15 @@ jobs:
   update:
     name: update
     runs-on: ubuntu-latest
-    
+
     steps:
       - uses: actions/checkout@v4
-      
+
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.12' # Need python version for cache
-          cache: 'pip' # caching pip dependencies
-          
+          python-version: "3.12" # Need python version for cache
+          cache: "pip" # caching pip dependencies
+
       - name: Cache GraphQL API IDs
         uses: actions/cache@v4
         with:
@@ -35,15 +35,15 @@ jobs:
           # Make sure even if the specs change it grabs the old cache
           # to start from! Entries are never invalidated, only added
           restore-keys: graphql-ids
-          
+
       - name: Install dependencies
         run: pip install -r requirements.txt
-        
+
       - name: Set git user to github-actions[bot]
         run: |
           git config --local user.name "github-actions[bot]"
           git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
-          
+
       - name: Check and update spec files
         run: python -m autocopr.autocopr --verbose --in-place --push specs
         env:

.mega-linter.yml

@@ -14,13 +14,22 @@ APPLY_FIXES: all
 # default
 # ENABLE_LINTERS:
 
+DISABLE_LINTERS:
+  - PYTHON_PYLINT
+  - PYTHON_FLAKE8
+  - REPOSITORY_TRIVY
+  - REPOSITORY_TRIVY_SBOM
+  - REPOSITORY_CHECKOV
+  - REPOSITORY_KICS
+
 DISABLE:
   # - COPYPASTE # Uncomment to disable checks of excessive copy-pastes
   - SPELL # Comment to enable checks of spelling mistakes
 
+PYTHON_BANDIT_DISABLE_ERRORS: true
+
 SHOW_ELAPSED_TIME: true
 
 FILEIO_REPORTER: false
-
 # Uncomment if you want MegaLinter to detect errors but not block CI to pass
 # DISABLE_ERRORS: true

README.md

@@ -1,6 +1,6 @@
 # Autocopr forked repo
 
-For any issues or questions related to python scripts, please go to upstream repo.
+## For any issues or questions related to python scripts, please go to upstream repo
 
 <details open>
 

autocopr/autocopr.py

@@ -15,20 +15,26 @@ def main():
     if args.verbose:
         logging.basicConfig(level=logging.INFO)
 
-    if (args.push
-            and subprocess.run(["git", "rev-parse", "--is-inside-work-tree"],
-                               capture_output=True).returncode != 0):
+    if (
+        args.push
+        and subprocess.run(
+            ["git", "rev-parse", "--is-inside-work-tree"], capture_output=True
+        ).returncode
+        != 0
+    ):
         # We're not in a git repository, exit
         logging.error("Cannot use --push when not running in a git repository")
         exit(1)
 
     specs = [
-        parsed for spec in root_dir.glob("**/*.spec")
+        parsed
+        for spec in root_dir.glob("**/*.spec")
         if (parsed := autocopr.specdata.parse_spec(spec)) is not None
     ]
 
     latest_vers = autocopr.latestver.get_latest_versions(
-        specs, args.github_token, root_dir / "graphql_id_cache.json")
+        specs, args.github_token, root_dir / "graphql_id_cache.json"
+    )
 
     update_summary = [f"{'Name':15}\t{'Old Version':8}\tNew Version"]
 
@@ -39,21 +45,22 @@ def main():
     ]
 
     if not args.dry_run:
-        for (spec, latest) in latest_vers:
+        for spec, latest in latest_vers:
             if spec.version != latest.ver:
-                autocopr.update.update_version(spec,
-                                               latest,
-                                               inplace=args.in_place,
-                                               push=args.push)
+                autocopr.update.update_version(
+                    spec, latest, inplace=args.in_place, push=args.push
+                )
 
     print("\n".join(update_summary))
 
     if args.dry_run:
         print("To update the spec files, run again without the dry-run flag.")
     elif not args.in_place:
-        print("If any specs were updated, the original spec files now have a "
-              ".bk suffix, and the spec files are updated with the newest "
-              "version.")
+        print(
+            "If any specs were updated, the original spec files now have a "
+            ".bk suffix, and the spec files are updated with the newest "
+            "version."
+        )
     else:
         print("Any updates have been applied to the spec files.")
 

autocopr/cli.py

@@ -6,7 +6,8 @@ def create_parser() -> argparse.ArgumentParser:
     """Initializes the cli parser."""
 
     parser = argparse.ArgumentParser(
-        description="Update versions in RPM Spec files and prepare commits.")
+        description="Update versions in RPM Spec files and prepare commits."
+    )
     parser.add_argument(
         "-p",
         "--push",
@@ -35,8 +36,11 @@ def create_parser() -> argparse.ArgumentParser:
     parser.add_argument(
         "--github-token",
         default=os.environ.get("GITHUB_TOKEN"),
-        help=("Github token to use to access the GraphQL API. "
-              "Defaults to GITHUB_TOKEN environment variable if not set."))
+        help=(
+            "Github token to use to access the GraphQL API. "
+            "Defaults to GITHUB_TOKEN environment variable if not set."
+        ),
+    )
     parser.add_argument(
         "directory",
         nargs="?",

autocopr/latestver.py

@@ -2,40 +2,46 @@
 from pathlib import Path
 from typing import Optional
 
-import requests
-
 import githubapi.graphql
 import githubapi.rest
+import requests
 from autocopr.specdata import SpecData
 from githubapi.latest import Latest
 
 
-def get_latest_versions(specs: list[SpecData], token: Optional[str],
-                        id_cache: Path) -> list[tuple[SpecData, Latest]]:
+def get_latest_versions(
+    specs: list[SpecData], token: Optional[str], id_cache: Path
+) -> list[tuple[SpecData, Latest]]:
     """Given a list of specs, optionally a Github token, and a location to load
     and store a cache of GraphQL ids, return a list of SpecData with latest version.
     Removes any SpecData that does not have a cooresponding version."""
 
     if token:
         logging.info(
             "GITHUB_TOKEN environment variable or --github-token flag is set, "
-            "using GraphQL api")
+            "using GraphQL api"
+        )
 
         ownerNames = [spec.ownerName for spec in specs]
         latest = githubapi.graphql.latest_versions(ownerNames, token, id_cache)
 
-        return [(spec, latest[key]) for spec in specs
-                if (key := spec.ownerName) in latest]
+        return [
+            (spec, latest[key]) for spec in specs if (key := spec.ownerName) in latest
+        ]
     else:
         logging.warning(
             "GITHUB_TOKEN environment variable or --github-token flag is not set, "
-            "using REST api instead of GraphQL.")
+            "using REST api instead of GraphQL."
+        )
         logging.warning(
             "The REST API requires more connections, gathers more data than is "
             "needed, and you are limited to 60 requests per hour without a token."
         )
 
         with requests.Session() as s:
-            return [(spec, latest_ver) for spec in specs
-                    if (latest_ver := githubapi.rest.get_latest_version(
-                        spec.ownerName, s)) is not None]
+            return [
+                (spec, latest_ver)
+                for spec in specs
+                if (latest_ver := githubapi.rest.get_latest_version(spec.ownerName, s))
+                is not None
+            ]

autocopr/specdata.py

@@ -12,6 +12,7 @@
 @dataclass(frozen=True)
 class SpecData:
     """Data from a parsed spec file."""
+
     ownerName: OwnerName
     version: str
     loc: Path
@@ -34,24 +35,22 @@ def parse_spec(spec_loc: Path) -> Optional[SpecData]:
         for line in spec:
             # Assumes Version and URL are only defined once in the file!
             # If there are duplicate definitions, behavior is undefined!
-            if (name_match := re.search(RegexConstants.name_pat,
-                                        line)) is not None:
+            if (name_match := re.search(RegexConstants.name_pat, line)) is not None:
                 logging.info(f'Got name from: "{line.rstrip()}"')
                 name = name_match.group(1)
-            elif (ver_match := re.search(RegexConstants.version_pat,
-                                         line)) is not None:
+            elif (ver_match := re.search(RegexConstants.version_pat, line)) is not None:
                 logging.info(f'Got version from: "{line.rstrip()}"')
                 version = ver_match.group(1)
-            elif (url_match := re.search(RegexConstants.url_pat,
-                                         line)) is not None:
+            elif (url_match := re.search(RegexConstants.url_pat, line)) is not None:
                 logging.info(f'Got url from: "{line.rstrip()}"')
                 # Remove any trailing slashes, we don't them for future API calls
-                url = urllib.parse.urlparse(url_match.group(1).rstrip('/'))
+                url = urllib.parse.urlparse(url_match.group(1).rstrip("/"))
                 if url.netloc != "github.com":
                     logging.warning(
                         f"{spec_loc} is hosted on {url.netloc} "
                         "but this script only checks projects from github, "
-                        "skipping this file")
+                        "skipping this file"
+                    )
                     return None
 
             if name is not None and version is not None and url is not None:

autocopr/update.py

@@ -7,19 +7,17 @@
 from githubapi.latest import Latest
 
 
-def update_version(spec: SpecData,
-                   latest: Latest,
-                   inplace: bool = False,
-                   push: bool = False):
+def update_version(
+    spec: SpecData, latest: Latest, inplace: bool = False, push: bool = False
+):
     """Given the location of a spec file, the latest version, and the name of
     the package, update the version in the spec and make a commit with the
     cooresponding COPR tag."""
 
     logging.info(f"Updating {spec.name} file to {latest.ver}...")
-    spec_loc_backup = spec.loc.rename(
-        spec.loc.with_suffix(spec.loc.suffix + ".bak"))
+    spec_loc_backup = spec.loc.rename(spec.loc.with_suffix(spec.loc.suffix + ".bak"))
 
-    with (open(spec.loc, "w") as new_spec, open(spec_loc_backup) as old_spec):
+    with open(spec.loc, "w") as new_spec, open(spec_loc_backup) as old_spec:
         # Again, assumes that Version and Release are only defined once!
         for line in old_spec:
             if re.match(RegexConstants.version_pat, line):
@@ -43,9 +41,9 @@ def update_version(spec: SpecData,
         subprocess.run(["git", "commit", "-m", commit_msg])
         # Have to make an annotated tag for github to recognize it
         # message is the same as the commit message
-        subprocess.run([
-            "git", "tag", "-a", "-m", commit_msg, f"{spec.name}-{latest.ver}"
-        ])
+        subprocess.run(
+            ["git", "tag", "-a", "-m", commit_msg, f"{spec.name}-{latest.ver}"]
+        )
         # The github webhooks won't fire if 3+ tags are made at once, to be
         # defensive push each tag by itself
         subprocess.run(["git", "push", "--follow-tags"])