Skip to content

Commit 08b520b

Browse files
ci(e2e): include test_wl_save.py in Python E2E workflow
The previous exclusion (--ignore=tests/e2e/test_wl_save.py) was added because 2 tests in that file were flaky in CI. Both were root-caused in commit 2864701 as test bugs (pagination trap + paginated-DOM-count assertions), not save-persistence anomalies. The suite now runs cleanly end-to-end. Baseline under playwright 1.60: 30 passed / 9 skipped / 0 errors. Also bumps the pytest --timeout from 90s to 120s to give the full suite headroom (~15-20 min total under load).
1 parent 2864701 commit 08b520b

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

.github/workflows/e2e-python.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ name: E2E Python (nightly + manual)
1111
# real app. See commits 25ff280..6fa38c3 for the rewrite. With this
1212
# workflow in place, regressions surface within 24h of merge.
1313
#
14-
# Scope (intentional exclusion):
15-
# - tests/e2e/test_wl_save.py is NOT run here. It has 2 known pre-existing
16-
# state-leak flakes (test_bulk_remove 10→10, test_add_row_and_save 10→7)
17-
# that block CI green. These are tracked in qa-findings.jsonl and will
18-
# be re-included in a follow-up commit once the underlying save-persistence
19-
# anomaly is investigated.
14+
# Scope (full Python E2E suite, including test_wl_save.py):
15+
# Previously test_wl_save.py was excluded due to 2 known flakes
16+
# (test_bulk_remove + test_add_row_and_save). Those turned out to be
17+
# test bugs (pagination trap + paginated-DOM-count assertions),
18+
# resolved in commit 2864701. The suite is now fully runnable.
2019
#
2120
# Triggers:
2221
# - schedule: nightly at 04:00 UTC (1h after e2e-full so a container
@@ -91,13 +90,12 @@ jobs:
9190
run: bash tests/e2e/setup_test_env.sh wl_manager_test
9291

9392
# ── Python E2E suite ─────────────────────────────────────────
94-
# Excludes test_wl_save.py — see header comment for the
95-
# save-persistence anomaly that blocks CI green there.
93+
# Full suite including test_wl_save.py. Baseline:
94+
# 30 passed, 9 skipped (all documented), 0 errors.
9695
- name: Run Python E2E suite
9796
run: |
9897
python -m pytest tests/e2e/ \
99-
--ignore=tests/e2e/test_wl_save.py \
100-
--timeout=90 \
98+
--timeout=120 \
10199
--tb=short \
102100
-v
103101

0 commit comments

Comments
 (0)