Skip to content

Commit 736f380

Browse files
docs(appinspect): refine re-eval triggers — separate SLIM allowlist update from action schema change
QA second-pass review of Phase 1.7 closure (commits 628a2b3 + ff9f8be) flagged that the previous trigger #3 conflated two distinct future events: (a) SLIM's underlying allowlist updates, causing check_that_app_passes_slim_validation_for_cloud to start passing — at which point set-equality between actual failures and expect.yaml keys produces "yaml lists a check that didn't fail" and FAILS the workflow until the entry is removed. (b) splunk/appinspect-api-action wrapper updates that change the expect.yaml file schema itself. Both are valid triggers but they look for different signals: (a) Cloud profile's Report info line shows failure: 0 with this file still in place. (b) Workflow exits with a YAML parse / schema error. Split into two numbered triggers and added the observable signal for (a). Mirrored in both files so the doc and the suppression artifact agree. No functional change. Documentation refinement only. QA-finding class: doc-precision-trigger-conflation.
1 parent ff9f8be commit 736f380

2 files changed

Lines changed: 21 additions & 4 deletions

File tree

.appinspect_api.expect.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,17 @@ check_that_app_passes_slim_validation_for_cloud: |
7474
narrative needs an update.
7575
2. The first human-reviewer feedback from Splunkbase Cloud Vetting
7676
— they may tell us the exact manifest format SLIM accepts.
77-
3. Any update to `splunk/appinspect-api-action` past v3.0.5 that
78-
changes the expect.yaml schema.
77+
3. Any SLIM allowlist update that makes
78+
`check_that_app_passes_slim_validation_for_cloud` start
79+
PASSING again. The action's
80+
`compare_against_known_failures` uses set-equality between
81+
actual and expected failures, so a spontaneously-passing
82+
check creates a yaml-lists-a-failure-that-didn't-occur
83+
mismatch and FAILS the workflow until this entry is deleted.
84+
Watch for the cloud profile's "Report info" line showing
85+
`failure: 0` despite this file existing.
86+
4. Any update to `splunk/appinspect-api-action` past v3.0.5
87+
that changes the expect.yaml schema itself.
7988
8089
Phase 1.6 dynamic-stage findings record: docs/APPINSPECT_FINDINGS.md
8190
§5.1 (headline numbers) + §5.2 (per-finding triage).

docs/APPINSPECT_FINDINGS.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,16 @@ in the file itself):
377377
2026-07-18 per CLAUDE.md).
378378
2. First human-reviewer feedback from Splunkbase Cloud Vetting on
379379
the actual submission — they may dictate the format SLIM accepts.
380-
3. Any update to `splunk/appinspect-api-action` past v3.0.5 that
381-
alters the expect.yaml schema.
380+
3. Any SLIM allowlist update that makes
381+
`check_that_app_passes_slim_validation_for_cloud` start passing
382+
again. The action's `compare_against_known_failures` is
383+
set-equality between actual and expected failure names; a
384+
spontaneously-passing check produces a "yaml lists a failure
385+
that didn't occur" mismatch and FAILS the workflow until this
386+
entry is removed. Watch for the cloud profile's `Report info`
387+
line showing `failure: 0` while this file still exists.
388+
4. Any update to `splunk/appinspect-api-action` past v3.0.5 that
389+
alters the expect.yaml schema itself.
382390

383391
**Phase 1.8 ("Per-finding triage on warnings + manual_checks") is
384392
unblocked**: warnings have been triaged unchanged at §3 above

0 commit comments

Comments
 (0)