Skip to content

Commit 9123a6c

Browse files
chore(deps-dev): remove unused pytest-playwright from requirements-dev.txt
`pytest-playwright` was declared in requirements-dev.txt but imported by zero files under tests/ — our Python E2E tests use `playwright.sync_api` directly via tests/e2e/conftest.py and tests/e2e/page_objects.py, not the pytest fixture wrapper. Removal unblocks Dependabot PR #12 cleanly: bumping the lower bound on an unused dep would just add churn for the next contributor. If we add fixture-style E2E later, we'll re-add pytest-playwright at the version we actually integrate against. Files: - requirements-dev.txt: drop the line + leave a maintenance comment so the next contributor understands why it's gone. - docs/SBOM.md: remove from the dev-deps enumeration + add a removal note pointing to this commit. Verified no remaining references via: grep -rn 'pytest_playwright\|pytest-playwright' tests/ requirements*.txt docs/
1 parent 18076c9 commit 9123a6c

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

docs/SBOM.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,14 @@ version-pinning audit (`CLAUDE.md` "Splunk Version Pinning Audit").
6565
Audited separately in `docs/PIP_AUDIT_LOG.md` (B4):
6666

6767
- `pytest`, `pytest-cov`, `freezegun`, `hypothesis`,
68-
`pytest-timeout`, `playwright`, `pytest-playwright`, `radon`
68+
`pytest-timeout`, `playwright`, `radon`
6969
- `playwright-core` (Node) for the E2E test runner
7070

71+
> `pytest-playwright` was removed from `requirements-dev.txt` on
72+
> 2026-05-23 — it was declared but never imported (E2E Python tests
73+
> use `playwright.sync_api` directly). See the commit referenced
74+
> from Dependabot PR #12 for rationale.
75+
7176
None of these are present in the .spl. They run only on developer
7277
machines and CI runners.
7378

requirements-dev.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@ freezegun==1.5.1
1010
hypothesis==6.90.0
1111
pytest-timeout==2.1.0
1212
playwright==1.40.0
13-
pytest-playwright>=0.4.0
13+
# pytest-playwright removed 2026-05-23 — was declared but never imported.
14+
# Our E2E Python tests use `playwright.sync_api` directly (see
15+
# tests/e2e/conftest.py + page_objects.py); the pytest-fixture wrapper
16+
# was never wired in. Removal unblocks Dependabot PR #12 cleanly:
17+
# bumping an unused dep just adds churn. If we add fixture-style E2E
18+
# later, re-add pytest-playwright at the version we actually integrate
19+
# against.
1420
# radon 6.1.1 was a typo / aspirational pin — never published to PyPI,
1521
# so `pip install -r requirements-dev.txt` failed for any new contributor.
1622
# 6.0.1 is the actual latest and is what `metrics_collector.py` was

0 commit comments

Comments
 (0)