Skip to content

Commit b20cbe1

Browse files
ci(unit-tests): drop stale tests/test_wl_hmac_key.py reference
The "Run module-level tests" step in ci.yml referenced tests/test_wl_hmac_key.py — a file that never existed. The result was every Unit Tests run on main red since the workflow landed (verified via gh run list --workflow=ci.yml -- 5+ consecutive failures on commits a48f6c2 / 4330149 / ab53066 / 91d9d22 / b14b3c9 all citing "ERROR: file or directory not found: tests/test_wl_hmac_key.py", exit code 4). HMAC coverage is already provided by tests/unit/test_hmac_key.py + tests/unit/test_hmac_sig_fuzz.py, both of which run via the prior `pytest tests/unit/` step. So removing the broken line loses zero coverage — it just unblocks the workflow. Same shape of fix as the round-7-B4 cleanup that removed a stale tests/test_wl_filelock.py reference. Updated the preamble comment to document BOTH missing-file gotchas so they don't get re-added by a future contributor reading the old comment as a TODO. Side benefit: this also unblocks the Unit Tests check on every open Dependabot PR (#7-#16), which were all red on the same missing-file error.
1 parent b14b3c9 commit b20cbe1

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,24 @@ jobs:
129129

130130
- name: Run module-level tests
131131
# Top-level tests/test_*.py files cover lower-layer modules
132-
# (wl_limits, wl_hmac_key, wl_fim_common, wl_expiration_cleanup)
133-
# with HMAC and period-boundary coverage that tests/unit/ does
134-
# not duplicate. Note: a former tests/test_wl_filelock.py
135-
# reference was removed during round 7 B4 — no such file
136-
# exists; the filelock paths are exercised inside
137-
# tests/unit/test_filelock.py.
132+
# (wl_limits, wl_fim_common, wl_expiration_cleanup) with
133+
# period-boundary + scheduled-input coverage that tests/unit/
134+
# does not duplicate.
135+
#
136+
# Notes on tests that LOOK like they should be in this list
137+
# but aren't:
138+
# - tests/test_wl_filelock.py: no such file ever existed
139+
# (filelock paths are exercised inside
140+
# tests/unit/test_filelock.py which runs in the prior step).
141+
# - tests/test_wl_hmac_key.py: same — no such file. HMAC
142+
# coverage lives at tests/unit/test_hmac_key.py +
143+
# tests/unit/test_hmac_sig_fuzz.py, both of which run in
144+
# the prior `pytest tests/unit/` step. A stale reference
145+
# to the non-existent top-level path was removed
146+
# 2026-05-22 — it was the cause of every red Unit Tests
147+
# run on main since the workflow landed.
138148
run: |
139149
python -m pytest tests/test_wl_limits.py \
140-
tests/test_wl_hmac_key.py \
141150
tests/test_wl_fim_common.py \
142151
tests/test_wl_expiration_cleanup.py \
143152
-q --tb=short

0 commit comments

Comments
 (0)