refactor: improve activity download response time (#1194)

AB#110799

Author: AntoineRelief

__tests__/unit-tests/routes/activity/activity.service.spec.ts

@@ -216,13 +216,25 @@ describe('Activity Service', () => {
       const query = {};
       const aggregationResult = [];
       const listAggregationMock = jest.spyOn(service as any, 'listAggregation');
-      listAggregationMock.mockResolvedValueOnce(aggregationResult);
+      // Count
+      listAggregationMock.mockReturnValueOnce({
+        count: () => [{ count: 20000 }],
+      });
+      // 2 pages
+      listAggregationMock.mockReturnValueOnce({
+        skip: jest.fn().mockReturnThis(),
+        limit: jest.fn().mockResolvedValueOnce(aggregationResult),
+      });
+      listAggregationMock.mockReturnValueOnce({
+        skip: jest.fn().mockReturnThis(),
+        limit: jest.fn().mockResolvedValueOnce(aggregationResult),
+      });
 
       const mockFile = Buffer.from('Test content');
       jest.spyOn(XLSBuilder, 'default').mockResolvedValueOnce(mockFile as any);
 
       const result = await service.downloadList(query);
-      expect(listAggregationMock).toHaveBeenCalled();
+      expect(listAggregationMock).toHaveBeenCalledTimes(3); // 1 for count, 2 for pagination
       expect(result).toEqual({
         fileName: (service as any).listExportFileName,
         file: mockFile,
@@ -235,7 +247,11 @@ describe('Activity Service', () => {
 
       const listAggregationMock = jest
         .spyOn(service as any, 'listAggregation')
-        .mockRejectedValueOnce(error);
+        .mockReturnValueOnce({
+          count: () => {
+            throw error;
+          },
+        });
 
       await expect(service.downloadList(query)).rejects.toThrow(error);
       expect(listAggregationMock).toHaveBeenCalled();

src/routes/activity/activity.service.ts

@@ -352,18 +352,33 @@ export class ActivityService {
         filters.push(queryFilters);
       }
 
-      const aggregation = await this.listAggregation(
+      const totalCountAggregation = await this.listAggregation(
         sortField,
         sortOrder,
         filters
-      );
-      const formattedData = aggregation.map((activity) => ({
-        timestamp: this.formatDate(activity.createdAt, timeZone),
-        userId: activity.userId?.toString(),
-        page: activity.metadata?.title || '',
-        username: activity.username,
-        attributes: activity.attributes,
-      }));
+      ).count('count');
+
+      const formattedData = [];
+
+      for (let skip = 0; skip < totalCountAggregation[0].count; skip += 10000) {
+        const aggregation = await this.listAggregation(
+          sortField,
+          sortOrder,
+          filters
+        )
+          .skip(skip)
+          .limit(1000);
+        formattedData.push(
+          ...aggregation.map((activity) => ({
+            timestamp: this.formatDate(activity.createdAt, timeZone),
+            userId: activity.userId?.toString(),
+            page: activity.metadata?.title || '',
+            username: activity.username,
+            attributes: activity.attributes,
+          }))
+        );
+      }
+
       const file = await xlsBuilder(
         this.listExportFileName,
         this.listExportColumns,