Skip to content

[Quality][Medium] Add optimistic-concurrency protection for savings goals #1632

Description

@Baskarayelu

Objective

Carry a version/etag through goal reads and mutations and provide conflict recovery without discarding unsaved user intent silently.

Why this matters

Two tabs or devices can overwrite a goal balance or target using stale data.

This is a substantive production-quality improvement. It must change runtime behavior, security guarantees, correctness, reliability, or meaningful user functionality. It is not a documentation-only, formatting-only, or trivial dependency task.

Scope

Area: savings goals

Starting points: lib/validation/savings-goals.ts, lib/hooks/useAutosave.ts, lib/hooks/useUserPreferences.ts, utils/types/savings-goals.ts

The contributor should verify the current implementation before changing it and keep the PR limited to this issue. Do not introduce unrelated refactors or weaken existing CI/security gates.

Acceptance criteria

  • Mutations include the version observed by the user.
  • Stale writes are rejected with a recoverable conflict state.
  • The UI presents server/local values and requires an explicit resolution.
  • Autosave retries do not overwrite a newer server version.

Required validation

  • Test two-tab stale update, autosave race, retry, and reload.

  • Test validation failures do not advance the version.

  • Add integration coverage for conflict resolution.

  • The PR explains the failure mode, the chosen design, backward-compatibility impact, and rollback or migration considerations.

  • The PR includes CI evidence and does not contain secrets, generated noise, unrelated cleanup, or disabled checks.

Contributor deliverables

  • Open a focused feature branch and do not begin implementation until assigned.
  • Reference this issue with Closes #<issue-number> or Fixes #<issue-number>.
  • Check off every acceptance criterion in the PR with links to the relevant code and tests.
  • Include a security/correctness note explaining why adversarial inputs cannot bypass the new guarantee.

Maintainer quality bar

The PR must be independently reviewable, preserve existing behavior outside this scope, exercise failure paths, and pass the repository's complete required CI/CD checks. Reward eligibility is not guaranteed by this issue or by merging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions