Skip to content

[Quality][Medium] Make currency, date, and locale formatting deterministic #1638

Description

@Baskarayelu

Objective

Separate canonical values from localized presentation and enforce explicit locale/timezone rules for all financial flows.

Why this matters

Locale-dependent parsing or formatting can display the wrong amount/date or send a value different from what the user reviewed.

This is a substantive production-quality improvement. It must change runtime behavior, security guarantees, correctness, reliability, or meaningful user functionality. It is not a documentation-only, formatting-only, or trivial dependency task.

Scope

Area: internationalization and financial display

Starting points: lib/i18n/formatters.ts, lib/utils/format-currency.ts, lib/i18n/resolve-locale.ts, lib/remittance

The contributor should verify the current implementation before changing it and keep the PR limited to this issue. Do not introduce unrelated refactors or weaken existing CI/security gates.

Acceptance criteria

  • Parsing never uses localized display strings as transaction inputs.
  • Currency code, precision, sign, and rounding are explicit.
  • Dates show the policy timezone and preserve the canonical instant.
  • Unsupported locales/currencies fall back deterministically without changing value.

Required validation

  • Test multiple locales, currencies, negative/zero/large amounts, and DST boundaries.

  • Test round-trip display/edit/submit behavior.

  • Add E2E assertions for localized confirmation values.

  • The PR explains the failure mode, the chosen design, backward-compatibility impact, and rollback or migration considerations.

  • The PR includes CI evidence and does not contain secrets, generated noise, unrelated cleanup, or disabled checks.

Contributor deliverables

  • Open a focused feature branch and do not begin implementation until assigned.
  • Reference this issue with Closes #<issue-number> or Fixes #<issue-number>.
  • Check off every acceptance criterion in the PR with links to the relevant code and tests.
  • Include a security/correctness note explaining why adversarial inputs cannot bypass the new guarantee.

Maintainer quality bar

The PR must be independently reviewable, preserve existing behavior outside this scope, exercise failure paths, and pass the repository's complete required CI/CD checks. Reward eligibility is not guaranteed by this issue or by merging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions