Remove dead network-model code superseded by NetworkState

The migration onto the Burst NetworkState left the old managed routing
orphaned. Delete the A* NetworkPathfinder and the explicit-mode half of
NetworkRoute it fed (the freestanding-path ctor, Empty, Contains, and the
BidirectionalEdge it compared against), leaving the live value-type view
into the Dijkstra forests. Drop the unused NetworkManager.FindNeighbors /
ConnectionCache / Count, the NetworkState.GetRouteLength / GetRouteOrigin
guid wrappers (callers use the internal index versions), the unused
VesselSatellite.Connections seam, and the never-referenced Dish type.

Author: Phantomical

src/RemoteTech/Network/NetworkState.cs

@@ -554,20 +554,6 @@ internal SatelliteMarkData ScheduleSatelliteMarks(in SatelliteMarkViewParams p)
         return new SatelliteMarkData { marks = marks, handle = h };
     }
 
-    /// <summary>
-    /// Get the distance between the requested satellite and its control point.
-    /// </summary>
-    /// <param name="sat"></param>
-    /// <param name="groundOnly">Only consider ground stations, not vessels.</param>
-    /// <returns>The length of network route, in meters.</returns>
-    public double GetRouteLength(ISatellite sat, bool groundOnly)
-    {
-        if (!satmap.TryGetValue(sat.Guid, out int index))
-            return double.PositiveInfinity;
-
-        return RouteLength(index, groundOnly);
-    }
-
     internal double RouteLength(int node, bool groundOnly)
     {
         var origin = GetOrigin(node, groundOnly);
@@ -601,19 +587,6 @@ internal bool RouteExists(int node, bool groundOnly)
         return origin >= 0 && origin != node;
     }
 
-    /// <summary>
-    /// Get the control station that is currently controlling this satellite.
-    /// </summary>
-    /// <param name="sat"></param>
-    /// <param name="groundOnly">Only consider ground stations, not vessels.</param>
-    public ISatellite GetRouteOrigin(ISatellite sat, bool groundOnly)
-    {
-        if (!satmap.TryGetValue(sat.Guid, out int index))
-            return null;
-
-        return RouteGoalSat(index, groundOnly);
-    }
-
     internal ISatellite RouteGoalSat(int node, bool groundOnly)
     {
         var origin = GetOrigin(node, groundOnly);

src/RemoteTech/NetworkManager.cs

@@ -21,8 +21,6 @@ public partial class NetworkManager : IEnumerable<ISatellite>
         public ArrayMap<Guid, CelestialBody> Planets { get; private set; } = new();
         public ArrayMap<Guid, ISatellite> GroundStations { get; private set; } = new();
 
-        public int Count => RTCore.Instance.Satellites.Count + GroundStations.Count;
-
         public static Guid ActiveVesselGuid => RTSettings.Instance.ActiveVesselGuidParsed;
 
         public ISatellite this[Guid guid]
@@ -111,8 +109,6 @@ public List<NetworkRoute<ISatellite>> this[ISatellite sat]
         internal IEnumerable<KeyValuePair<Guid, List<NetworkLink<ISatellite>>>> EnumerateLinks() =>
             current?.EnumerateLinks() ?? Enumerable.Empty<KeyValuePair<Guid, List<NetworkLink<ISatellite>>>>();
 
-        internal Dictionary<ISatellite, List<NetworkRoute<ISatellite>>> ConnectionCache => mConnectionCache;
-
         /// <summary>
         /// This tick's state — freshest positions, but not yet completed; callers pay for <see cref="NetworkState.Complete"/> if it's still running.
         /// </summary>
@@ -162,20 +158,6 @@ public void Dispose()
             next?.Dispose();
         }
 
-        /// <summary>
-        /// Powered (and, when signal relay is on, relay-capable) neighbours of
-        /// <paramref name="s"/>, resolved from the current state's adjacency. Used
-        /// by the on-demand A* path query exposed through the public API.
-        /// </summary>
-        public IEnumerable<NetworkLink<ISatellite>> FindNeighbors(ISatellite s)
-        {
-            if (s == null || !s.Powered || current == null) return Enumerable.Empty<NetworkLink<ISatellite>>();
-            var links = current.GetLinks(s);
-            if (RTSettings.Instance.SignalRelayEnabled)
-                return links.Where(l => l.Target.Powered && l.Target.CanRelaySignal);
-            return links.Where(l => l.Target.Powered);
-        }
-
         public static NetworkLink<ISatellite>? GetLink(ISatellite sat_a, ISatellite sat_b)
         {
             if (sat_a == null || sat_b == null || sat_a == sat_b) return null;

src/RemoteTech/NetworkPathfinder.cs

@@ -0,0 +1,8 @@
+namespace RemoteTech.SimpleTypes;
+
+public enum LinkType : byte
+{
+    None,
+    Dish,
+    Omni,
+}

src/RemoteTech/SimpleTypes/BidirectionalEdge.cs

@@ -5,90 +5,39 @@
 namespace RemoteTech.SimpleTypes
 {
     /// <summary>
-    /// A connection route, as a value-type view. In <b>view mode</b> the route is
-    /// a lightweight handle into the persistent <see cref="NetworkState"/>
-    /// (<c>_state != null</c>): <see cref="Length"/>/<see cref="Goal"/>/
+    /// A connection route, as a value-type view: a lightweight handle into the
+    /// persistent <see cref="NetworkState"/>. <see cref="Length"/>/<see cref="Goal"/>/
     /// <see cref="Exists"/> are answered O(1) from the Dijkstra forests, and the
     /// hop list is materialized lazily — and cached per tick by the state — only
-    /// when <see cref="Links"/> is actually read. In <b>explicit mode</b>
-    /// (<c>_state == null</c>) it wraps a freestanding path, e.g. the result of the
-    /// A* <see cref="NetworkPathfinder"/> or <see cref="NetworkRoute.Empty{T}"/>.
+    /// when <see cref="Links"/> is actually read.
     /// </summary>
     public readonly struct NetworkRoute<T> : IComparable<NetworkRoute<T>>
     {
-        // View mode.
         private readonly NetworkState _state;
         private readonly int _node;
         private readonly bool _groundOnly;
 
-        // Explicit mode.
-        private readonly T _start;
-        private readonly IReadOnlyList<NetworkLink<T>> _links;
-        private readonly double _length;
-
-        private static readonly NetworkLink<T>[] NoLinks = new NetworkLink<T>[0];
-
-        public NetworkRoute(T start, IReadOnlyList<NetworkLink<T>> links, double dist)
-        {
-            if (start == null) throw new ArgumentNullException(nameof(start));
-            _state = null;
-            _node = -1;
-            _groundOnly = false;
-            _start = start;
-            _links = links;
-            _length = dist;
-        }
-
         internal NetworkRoute(NetworkState state, int node, bool groundOnly)
         {
             _state = state;
             _node = node;
             _groundOnly = groundOnly;
-            _start = default;
-            _links = null;
-            _length = 0.0;
         }
 
-        public T Start => _state != null ? (T)(object)_state.SatAt(_node) : _start;
+        public T Start => (T)(object)_state.SatAt(_node);
 
-        public double Length => _state != null ? _state.RouteLength(_node, _groundOnly) : _length;
+        public double Length => _state.RouteLength(_node, _groundOnly);
 
-        public bool Exists => _state != null
-            ? _state.RouteExists(_node, _groundOnly)
-            : _links != null && _links.Count > 0;
+        public bool Exists => _state.RouteExists(_node, _groundOnly);
 
         public double Delay => RTSettings.Instance.EnableSignalDelay
             ? Length / RTSettings.Instance.SpeedOfLight
             : 0.0;
 
-        public IReadOnlyList<NetworkLink<T>> Links => _state != null
-            ? (IReadOnlyList<NetworkLink<T>>)(object)_state.RouteHops(_node, _groundOnly)
-            : _links ?? NoLinks;
-
-        public T Goal
-        {
-            get
-            {
-                if (!Exists) return default;
-                if (_state != null) return (T)(object)_state.RouteGoalSat(_node, _groundOnly);
-                return _links[_links.Count - 1].Target;
-            }
-        }
+        public IReadOnlyList<NetworkLink<T>> Links =>
+            (IReadOnlyList<NetworkLink<T>>)(object)_state.RouteHops(_node, _groundOnly);
 
-        public bool Contains(BidirectionalEdge<T> edge)
-        {
-            var links = Links;
-            if (links.Count == 0) return false;
-            T start = Start;
-            if ((start.Equals(edge.A) && links[0].Target.Equals(edge.B)) ||
-                (start.Equals(edge.B) && links[0].Target.Equals(edge.A))) return true;
-            for (int i = 0; i < links.Count - 1; i++)
-            {
-                if (links[i].Target.Equals(edge.A) && links[i + 1].Target.Equals(edge.B)) return true;
-                if (links[i].Target.Equals(edge.B) && links[i + 1].Target.Equals(edge.A)) return true;
-            }
-            return false;
-        }
+        public T Goal => Exists ? (T)(object)_state.RouteGoalSat(_node, _groundOnly) : default;
 
         public int CompareTo(NetworkRoute<T> other) => Length.CompareTo(other.Length);
 
@@ -101,12 +50,4 @@ public override string ToString()
                 String.Join("→", parts), Length.ToString("F2") + "m");
         }
     }
-
-    public class NetworkRoute
-    {
-        public static NetworkRoute<T> Empty<T>(T start)
-        {
-            return new NetworkRoute<T>(start, null, Single.PositiveInfinity);
-        }
-    }
 }

src/RemoteTech/SimpleTypes/Dish.cs

@@ -189,11 +189,6 @@ public bool HasLocalControl
          * Helpers
          */
 
-        /// <summary>
-        /// List of network routes for the satellite.
-        /// </summary>
-        public List<NetworkRoute<ISatellite>> Connections => RTCore.Instance.Network[this];
-
         /// <summary>
         /// Called on connection refresh to update the connections.
         /// </summary>