Skip to content

Commit e766297

Browse files
committed
bugfix in linux RPM package generation
1 parent 59e474e commit e766297

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

common/cmake/package.cmake

+3-2
Original file line numberDiff line numberDiff line change
@@ -254,15 +254,16 @@ ELSE()
254254
SET(CPACK_RPM_lib_POST_UNINSTALL_SCRIPT_FILE ${PROJECT_SOURCE_DIR}/common/cmake/rpm_ldconfig.sh)
255255
IF (EMBREE_TESTING_PACKAGE)
256256
ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh
257-
${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE})
257+
${EMBREE_ZIP_MODE} ${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE})
258258
ENDIF()
259259
ELSE()
260260

261261
SET(CPACK_GENERATOR TGZ)
262262
SET(CPACK_PACKAGE_FILE_NAME "${CPACK_PACKAGE_FILE_NAME}.x86_64.linux")
263263
SET(CPACK_MONOLITHIC_INSTALL 1)
264264
IF (EMBREE_TESTING_PACKAGE)
265-
ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh ${EMBREE_ZIP_MODE} ${EMBREE_VERSION} ${EMBREE_SIGN_FILE})
265+
ADD_TEST(NAME "BuildPackage" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMAND ${PROJECT_SOURCE_DIR}/scripts/package_linux.sh
266+
${EMBREE_ZIP_MODE} ${EMBREE_LIBRARY_NAME} ${EMBREE_VERSION} ${EMBREE_VERSION_MAJOR} ${EMBREE_SIGN_FILE})
266267
ENDIF()
267268
ENDIF()
268269

scripts/package_linux.sh

+7-6
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,11 @@ function check_symbols
4040
}
4141

4242
# read embree version
43-
EMBREE_LIBRARY_NAME=$1
44-
EMBREE_VERSION=$2
45-
EMBREE_VERSION_MAJOR=$3
46-
EMBREE_SIGN_FILE=$4
43+
EMBREE_ZIP_MODE=$1
44+
EMBREE_LIBRARY_NAME=$2
45+
EMBREE_VERSION=$3
46+
EMBREE_VERSION_MAJOR=$4
47+
EMBREE_SIGN_FILE=$5
4748

4849
# create package
4950
make -j 16 preinstall
@@ -52,10 +53,10 @@ check_symbols lib${EMBREE_LIBRARY_NAME}.so GLIBCXX 3 4 11
5253
check_symbols lib${EMBREE_LIBRARY_NAME}.so CXXABI 1 3 0
5354
make -j 16 package
5455

55-
if [ "$1" == "OFF" ]; then
56+
if [ "$EMBREE_ZIP_MODE" == "OFF" ]; then
5657

5758
# sign all RPM files
58-
if [ $# -eq 4 ]; then
59+
if [ $# -eq 5 ]; then
5960
${EMBREE_SIGN_FILE} embree${EMBREE_VERSION_MAJOR}-*-${EMBREE_VERSION}-*.rpm
6061
fi
6162

0 commit comments

Comments
 (0)