Skip to content

Commit 94a6f93

Browse files
andy31415andreilitvin
andy31415
and
andreilitvin
authored
Thread diagnostics to spec (project-chip#30153)
* Rename active network faults: no list suffix in spec * Add invoke privilege to ResetCounts * zap regen * switch data type and set a correct max for leader router id * Zap regen * Mass rename ActiveNetworkFaultsList to ActiveNetworkFaults * undo availability yaml changes * zap regen * minor change to kick CI * Another minor edit, see if restyler becomes happy * Rename back to ActiveNetworkFaultsList * More renames back to List suffix * Fix yaml test naming * restyle * run zap regen to get kotlin updates --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
1 parent 71a72ae commit 94a6f93

73 files changed

Lines changed: 204 additions & 195 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.matter‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -839,9 +839,9 @@ server cluster ThreadNetworkDiagnostics = 53 {
839839
readonly attribute NeighborTableStruct neighborTable[] = 7;
840840
readonly attribute RouteTableStruct routeTable[] = 8;
841841
readonly attribute nullable int32u partitionId = 9;
842-
readonly attribute nullable int8u weighting = 10;
843-
readonly attribute nullable int8u dataVersion = 11;
844-
readonly attribute nullable int8u stableDataVersion = 12;
842+
readonly attribute nullable int16u weighting = 10;
843+
readonly attribute nullable int16u dataVersion = 11;
844+
readonly attribute nullable int16u stableDataVersion = 12;
845845
readonly attribute nullable int8u leaderRouterId = 13;
846846
readonly attribute int16u detachedRoleCount = 14;
847847
readonly attribute int16u childRoleCount = 15;
@@ -899,7 +899,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
899899
readonly attribute bitmap32 featureMap = 65532;
900900
readonly attribute int16u clusterRevision = 65533;
901901

902-
command ResetCounts(): DefaultSuccess = 0;
902+
command access(invoke: manage) ResetCounts(): DefaultSuccess = 0;
903903
}
904904

905905
/** The Wi-Fi Network Diagnostics Cluster provides a means to acquire standardized diagnostics metrics that MAY be used by a Node to assist a user or Administrative Node in diagnosing potential problems. */

‎examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.zap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2660,7 +2660,7 @@
26602660
"reportableChange": 0
26612661
},
26622662
{
2663-
"name": "ActiveNetworkFaultsList",
2663+
"name": "ActiveNetworkFaults",
26642664
"code": 62,
26652665
"mfgCode": null,
26662666
"side": "server",

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.matter‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1818,9 +1818,9 @@ server cluster ThreadNetworkDiagnostics = 53 {
18181818
readonly attribute NeighborTableStruct neighborTable[] = 7;
18191819
readonly attribute RouteTableStruct routeTable[] = 8;
18201820
readonly attribute nullable int32u partitionId = 9;
1821-
readonly attribute nullable int8u weighting = 10;
1822-
readonly attribute nullable int8u dataVersion = 11;
1823-
readonly attribute nullable int8u stableDataVersion = 12;
1821+
readonly attribute nullable int16u weighting = 10;
1822+
readonly attribute nullable int16u dataVersion = 11;
1823+
readonly attribute nullable int16u stableDataVersion = 12;
18241824
readonly attribute nullable int8u leaderRouterId = 13;
18251825
readonly attribute int16u detachedRoleCount = 14;
18261826
readonly attribute int16u childRoleCount = 15;
@@ -1878,7 +1878,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
18781878
readonly attribute bitmap32 featureMap = 65532;
18791879
readonly attribute int16u clusterRevision = 65533;
18801880

1881-
command ResetCounts(): DefaultSuccess = 0;
1881+
command access(invoke: manage) ResetCounts(): DefaultSuccess = 0;
18821882
}
18831883

18841884
/** The Wi-Fi Network Diagnostics Cluster provides a means to acquire standardized diagnostics metrics that MAY be used by a Node to assist a user or Administrative Node in diagnosing potential problems. */

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.zap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4122,7 +4122,7 @@
41224122
"reportableChange": 0
41234123
},
41244124
{
4125-
"name": "ActiveNetworkFaultsList",
4125+
"name": "ActiveNetworkFaults",
41264126
"code": 62,
41274127
"mfgCode": null,
41284128
"side": "server",

‎examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,9 +1630,9 @@ server cluster ThreadNetworkDiagnostics = 53 {
16301630
readonly attribute NeighborTableStruct neighborTable[] = 7;
16311631
readonly attribute RouteTableStruct routeTable[] = 8;
16321632
readonly attribute nullable int32u partitionId = 9;
1633-
readonly attribute nullable int8u weighting = 10;
1634-
readonly attribute nullable int8u dataVersion = 11;
1635-
readonly attribute nullable int8u stableDataVersion = 12;
1633+
readonly attribute nullable int16u weighting = 10;
1634+
readonly attribute nullable int16u dataVersion = 11;
1635+
readonly attribute nullable int16u stableDataVersion = 12;
16361636
readonly attribute nullable int8u leaderRouterId = 13;
16371637
readonly attribute nullable SecurityPolicy securityPolicy = 59;
16381638
readonly attribute nullable octet_string<4> channelPage0Mask = 60;

‎examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2856,7 +2856,7 @@
28562856
"reportableChange": 0
28572857
},
28582858
{
2859-
"name": "ActiveNetworkFaultsList",
2859+
"name": "ActiveNetworkFaults",
28602860
"code": 62,
28612861
"mfgCode": null,
28622862
"side": "server",

‎examples/bridge-app/bridge-common/bridge-app.matter‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1148,9 +1148,9 @@ server cluster ThreadNetworkDiagnostics = 53 {
11481148
readonly attribute NeighborTableStruct neighborTable[] = 7;
11491149
readonly attribute RouteTableStruct routeTable[] = 8;
11501150
readonly attribute nullable int32u partitionId = 9;
1151-
readonly attribute nullable int8u weighting = 10;
1152-
readonly attribute nullable int8u dataVersion = 11;
1153-
readonly attribute nullable int8u stableDataVersion = 12;
1151+
readonly attribute nullable int16u weighting = 10;
1152+
readonly attribute nullable int16u dataVersion = 11;
1153+
readonly attribute nullable int16u stableDataVersion = 12;
11541154
readonly attribute nullable int8u leaderRouterId = 13;
11551155
readonly attribute int16u detachedRoleCount = 14;
11561156
readonly attribute int16u childRoleCount = 15;

‎examples/bridge-app/bridge-common/bridge-app.zap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3167,7 +3167,7 @@
31673167
"reportableChange": 0
31683168
},
31693169
{
3170-
"name": "ActiveNetworkFaultsList",
3170+
"name": "ActiveNetworkFaults",
31713171
"code": 62,
31723172
"mfgCode": null,
31733173
"side": "server",

‎examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,9 +1022,9 @@ server cluster ThreadNetworkDiagnostics = 53 {
10221022
readonly attribute NeighborTableStruct neighborTable[] = 7;
10231023
readonly attribute RouteTableStruct routeTable[] = 8;
10241024
readonly attribute nullable int32u partitionId = 9;
1025-
readonly attribute nullable int8u weighting = 10;
1026-
readonly attribute nullable int8u dataVersion = 11;
1027-
readonly attribute nullable int8u stableDataVersion = 12;
1025+
readonly attribute nullable int16u weighting = 10;
1026+
readonly attribute nullable int16u dataVersion = 11;
1027+
readonly attribute nullable int16u stableDataVersion = 12;
10281028
readonly attribute nullable int8u leaderRouterId = 13;
10291029
readonly attribute int16u detachedRoleCount = 14;
10301030
readonly attribute int16u childRoleCount = 15;
@@ -1082,7 +1082,7 @@ server cluster ThreadNetworkDiagnostics = 53 {
10821082
readonly attribute bitmap32 featureMap = 65532;
10831083
readonly attribute int16u clusterRevision = 65533;
10841084

1085-
command ResetCounts(): DefaultSuccess = 0;
1085+
command access(invoke: manage) ResetCounts(): DefaultSuccess = 0;
10861086
}
10871087

10881088
/** The Wi-Fi Network Diagnostics Cluster provides a means to acquire standardized diagnostics metrics that MAY be used by a Node to assist a user or Administrative Node in diagnosing potential problems. */

‎examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.zap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2632,7 +2632,7 @@
26322632
"reportableChange": 0
26332633
},
26342634
{
2635-
"name": "ActiveNetworkFaultsList",
2635+
"name": "ActiveNetworkFaults",
26362636
"code": 62,
26372637
"mfgCode": null,
26382638
"side": "server",

0 commit comments

Comments
 (0)