chore(golangci): update golangci-lint configuration to version 2 and enable formatters for gofmt and goimports

fix(tests): change file permission mode from octal 0644 to 0o644 for consistency with Go 1.19+ syntax

fix(config): change file permission mode from octal 0600 to 0o600 for consistency with Go 1.19+ syntax

refactor(help): rename variable max to maxLen for better clarity in maxCommandNameLen function

chore(ui): remove unused error formatting variable errFmt from ui.go

chore(webhooks): remove unused line from webhooks.go

chore(binary_test): clean up temporary directory after running tests in TestMain

fix(client): replace nil with http.NoBody in NewRequestWithContext for clarity

style(client_test): simplify deferred body closing in tests for better readability

chore(config): change file permission mode from octal 0755 to 0o755 for consistency with Go 1.19+ syntax

Author: ariel-frischer

.golangci.yml

@@ -1,3 +1,10 @@
+version: "2"
+
+formatters:
+  enable:
+    - gofmt
+    - goimports
+
 linters:
   enable:
     - errcheck
@@ -6,20 +13,23 @@ linters:
     - unused
     - ineffassign
     - gocritic
-    - gofmt
-    - goimports
     - misspell
-
-linters-settings:
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - style
-  misspell:
-    locale: US
-
-issues:
-  exclude-dirs:
-    - vendor
-  max-issues-per-linter: 50
-  max-same-issues: 10
+  exclusions:
+    paths:
+      - vendor
+    rules:
+      - path: _test\.go
+        linters:
+          - errcheck
+  settings:
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - style
+    misspell:
+      locale: US
+      extra-words:
+        - typo: cancelled
+          correction: cancelled
+        - typo: cancelling
+          correction: cancelling

cmd/rentalot/bulk_import_test.go

@@ -10,7 +10,7 @@ func TestLoadImportFile_CSV(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "test.csv")
 	content := "name,email,phone\nAlice,alice@example.com,555-0001\nBob,bob@example.com,555-0002\n"
-	if err := os.WriteFile(path, []byte(content), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -33,7 +33,7 @@ func TestLoadImportFile_JSON(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "test.json")
 	content := `[{"name":"Alice","email":"alice@example.com"},{"name":"Bob","email":"bob@example.com"}]`
-	if err := os.WriteFile(path, []byte(content), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -53,7 +53,7 @@ func TestLoadImportFile_JSONUpperCase(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "test.JSON")
 	content := `[{"id":"1"}]`
-	if err := os.WriteFile(path, []byte(content), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -76,7 +76,7 @@ func TestLoadImportFile_MissingFile(t *testing.T) {
 func TestLoadImportFile_InvalidJSON(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "bad.json")
-	if err := os.WriteFile(path, []byte(`{invalid`), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(`{invalid`), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -90,7 +90,7 @@ func TestLoadImportFile_EmptyCSV(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "empty.csv")
 	content := "name,email\n"
-	if err := os.WriteFile(path, []byte(content), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -107,7 +107,7 @@ func TestLoadImportFile_CSVTrimHeaders(t *testing.T) {
 	dir := t.TempDir()
 	path := filepath.Join(dir, "spaces.csv")
 	content := " name , email \nAlice,alice@test.com\n"
-	if err := os.WriteFile(path, []byte(content), 0644); err != nil {
+	if err := os.WriteFile(path, []byte(content), 0o644); err != nil {
 		t.Fatal(err)
 	}
 

cmd/rentalot/commands_test.go

@@ -727,7 +727,7 @@ func TestWebhooksTestCmd_TableOutput(t *testing.T) {
 func TestBulkImportRun_Success(t *testing.T) {
 	dir := t.TempDir()
 	csvPath := dir + "/import.csv"
-	if err := os.WriteFile(csvPath, []byte("name,email\nAlice,a@t.com\n"), 0644); err != nil {
+	if err := os.WriteFile(csvPath, []byte("name,email\nAlice,a@t.com\n"), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -761,7 +761,7 @@ func TestBulkImportRun_Success(t *testing.T) {
 func TestBulkImportRun_NoPoll(t *testing.T) {
 	dir := t.TempDir()
 	csvPath := dir + "/import.csv"
-	if err := os.WriteFile(csvPath, []byte("name,email\nAlice,a@t.com\n"), 0644); err != nil {
+	if err := os.WriteFile(csvPath, []byte("name,email\nAlice,a@t.com\n"), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -782,7 +782,7 @@ func TestBulkImportRun_NoPoll(t *testing.T) {
 func TestBulkImportRun_EmptyFile(t *testing.T) {
 	dir := t.TempDir()
 	csvPath := dir + "/empty.csv"
-	if err := os.WriteFile(csvPath, []byte("name,email\n"), 0644); err != nil {
+	if err := os.WriteFile(csvPath, []byte("name,email\n"), 0o644); err != nil {
 		t.Fatal(err)
 	}
 
@@ -802,7 +802,7 @@ func TestBulkImportRun_EmptyFile(t *testing.T) {
 func TestBulkImportRun_APIError(t *testing.T) {
 	dir := t.TempDir()
 	csvPath := dir + "/import.csv"
-	if err := os.WriteFile(csvPath, []byte("name\nAlice\n"), 0644); err != nil {
+	if err := os.WriteFile(csvPath, []byte("name\nAlice\n"), 0o644); err != nil {
 		t.Fatal(err)
 	}
 

cmd/rentalot/config.go

@@ -62,7 +62,7 @@ func runConfigInit(cmd *cobra.Command, args []string) error {
 	if err := rentalotcli.SaveConfig(&rentalotcli.Config{}, globalConfigFile); err != nil {
 		return err
 	}
-	if err := os.WriteFile(globalConfigFile, []byte(content), 0600); err != nil {
+	if err := os.WriteFile(globalConfigFile, []byte(content), 0o600); err != nil {
 		return fmt.Errorf("writing config: %w", err)
 	}
 	success("Created %s", fileRef(globalConfigFile))

cmd/rentalot/help.go

@@ -116,11 +116,11 @@ func visibleSubcommands(cmd *cobra.Command) []*cobra.Command {
 }
 
 func maxCommandNameLen(cmds []*cobra.Command) int {
-	max := 0
+	maxLen := 0
 	for _, c := range cmds {
-		if len(c.Name()) > max {
-			max = len(c.Name())
+		if len(c.Name()) > maxLen {
+			maxLen = len(c.Name())
 		}
 	}
-	return max
+	return maxLen
 }

cmd/rentalot/ui.go

@@ -9,7 +9,6 @@ import (
 var (
 	successFmt = color.New(color.FgGreen)
 	warnFmt    = color.New(color.FgYellow)
-	errFmt     = color.New(color.FgRed)
 	boldFmt    = color.New(color.Bold)
 	fileFmt    = color.New(color.FgCyan)
 	versionFmt = color.New(color.FgMagenta, color.Bold)
@@ -39,4 +38,3 @@ func fileRef(s string) string {
 func versionRef(s string) string {
 	return versionFmt.Sprint(s)
 }
-

cmd/rentalot/webhooks.go

@@ -192,4 +192,3 @@ func webhooksTestCmd() *cobra.Command {
 		},
 	}
 }
-

e2e/binary_test.go

@@ -21,8 +21,6 @@ func TestMain(m *testing.M) {
 	if err != nil {
 		panic(err)
 	}
-	defer os.RemoveAll(tmp)
-
 	bin := filepath.Join(tmp, "rentalot")
 	if runtime.GOOS == "windows" {
 		bin += ".exe"
@@ -34,7 +32,9 @@ func TestMain(m *testing.M) {
 	}
 	binaryPath = bin
 
-	os.Exit(m.Run())
+	code := m.Run()
+	os.RemoveAll(tmp)
+	os.Exit(code)
 }
 
 // runBinary executes the CLI binary with the given args and env overrides.

pkg/rentalotcli/client.go

@@ -95,7 +95,7 @@ func (c *Client) do(ctx context.Context, method, rawURL string, body *strings.Re
 	if body != nil {
 		req, err = http.NewRequestWithContext(ctx, method, rawURL, body)
 	} else {
-		req, err = http.NewRequestWithContext(ctx, method, rawURL, nil)
+		req, err = http.NewRequestWithContext(ctx, method, rawURL, http.NoBody)
 	}
 	if err != nil {
 		return nil, fmt.Errorf("creating request: %w", err)

pkg/rentalotcli/client_test.go

@@ -57,7 +57,7 @@ func TestGet_WithQueryParams(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
-	defer func() { _ = resp.Body.Close() }()
+	_ = resp.Body.Close()
 }
 
 func TestGet_EmptyParamsIgnored(t *testing.T) {
@@ -74,7 +74,7 @@ func TestGet_EmptyParamsIgnored(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
-	defer func() { _ = resp.Body.Close() }()
+	_ = resp.Body.Close()
 }
 
 func TestPost_SendsJSONBody(t *testing.T) {
@@ -123,7 +123,7 @@ func TestPatch_SendsJSONBody(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unexpected error: %v", err)
 	}
-	defer func() { _ = resp.Body.Close() }()
+	_ = resp.Body.Close()
 }
 
 func TestDelete_SendsDeleteRequest(t *testing.T) {