We should use/point to sourcedata/raw not sourcedata #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
approved these changes
May 23, 2025
Member
asmacdo
left a comment
asmacdo
left a comment
There was a problem hiding this comment.
LGTM. (my force push was to remove an additional commit I made in error)
Member
|
CI failures are unrelated, but prevent running the script we changed. we should merge #140 first so we can let the CI be green prior to merge. Also FWIW, its odd to me that |
Member
Author
|
RE raw, it is what it is ATM. There was quite a bit of discussion, heh. To be redefined, offer suggestion against BIDS specification. Here we just use best/recommended practice. |
Member
|
rebased to include shellcheck fix so we can see the tests run |
Member
|
Ah the real reason the test didnt run is fixed by #141, lets merge that first |
yarikoptic
force-pushed
the
rf-sourcedata
branch
from
f9a1b3b to
2d0fbf6
Compare
Member
Author
|
Ok, green now - let's proceed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://bids-specification.readthedocs.io/en/stable/common-principles.html#source-vs-raw-vs-derived-data and our examples at
bids-standard/bids-specification#1861 (comment) and there on