BB-T43 PR#119 fixes

Author: ucswift

src/lib/auth/api.tsx

@@ -25,6 +25,18 @@ authApi.interceptors.request.use((config) => {
 });
 
 export const loginRequest = async (credentials: LoginCredentials): Promise<LoginResponse> => {
+  // GDPR Art. 5(1)(c) data minimization: never log raw username PII.
+  // Computed before the try block (with its own fallback) so the hash is
+  // available in both success and error paths without an unguarded await
+  // inside catch.
+  let username_hash = 'unavailable';
+  try {
+    username_hash = await Crypto.digestStringAsync(Crypto.CryptoDigestAlgorithm.SHA256, credentials.username);
+  } catch {
+    // Hashing failed (e.g. crypto backend unavailable) — keep placeholder.
+  }
+  const gdpr = { purpose: 'auth', lawful_basis: 'contract' } as const;
+
   try {
     const data = queryString.stringify({
       grant_type: 'password',
@@ -33,10 +45,6 @@ export const loginRequest = async (credentials: LoginCredentials): Promise<Login
       scope: Env.IS_MOBILE_APP ? 'openid profile offline_access mobile' : 'openid profile offline_access',
     });
 
-    // GDPR Art. 5(1)(c) data minimization: never log raw username PII.
-    const username_hash = await Crypto.digestStringAsync(Crypto.CryptoDigestAlgorithm.SHA256, credentials.username);
-    const gdpr = { purpose: 'auth', lawful_basis: 'contract' } as const;
-
     logger.info({
       message: 'API: Sending login request',
       context: { username_hash, baseURL: authApi.defaults.baseURL, gdpr },
@@ -73,14 +81,13 @@ export const loginRequest = async (credentials: LoginCredentials): Promise<Login
       };
     }
   } catch (error) {
-    const username_hash = await Crypto.digestStringAsync(Crypto.CryptoDigestAlgorithm.SHA256, credentials.username);
     logger.error({
       message: 'Login API call failed with exception',
       context: {
         error: error instanceof Error ? error.message : String(error),
         status: axios.isAxiosError(error) ? error.response?.status : undefined,
         username_hash,
-        gdpr: { purpose: 'auth', lawful_basis: 'contract' },
+        gdpr,
       },
     });
 

src/services/signalr.service.ts

@@ -196,9 +196,7 @@ class SignalRService {
       // Set up event handlers
       connection.onclose((error) => {
         this.handleConnectionClose(config.name);
-        if (error) {
-          this.notifyConnectionStateCallbacks(config.name, 'onError', error);
-        }
+        this.notifyConnectionError(config.name, error);
         this.notifyConnectionStateCallbacks(config.name, 'onClose');
       });
 
@@ -207,9 +205,7 @@ class SignalRService {
           message: `Reconnecting to hub: ${config.name}`,
           context: { error },
         });
-        if (error) {
-          this.notifyConnectionStateCallbacks(config.name, 'onError', error);
-        }
+        this.notifyConnectionError(config.name, error);
         this.notifyConnectionStateCallbacks(config.name, 'onReconnecting');
       });
 
@@ -332,9 +328,7 @@ class SignalRService {
       // Set up event handlers
       connection.onclose((error) => {
         this.handleConnectionClose(config.name);
-        if (error) {
-          this.notifyConnectionStateCallbacks(config.name, 'onError', error);
-        }
+        this.notifyConnectionError(config.name, error);
         this.notifyConnectionStateCallbacks(config.name, 'onClose');
       });
 
@@ -343,9 +337,7 @@ class SignalRService {
           message: `Reconnecting to hub: ${config.name}`,
           context: { error },
         });
-        if (error) {
-          this.notifyConnectionStateCallbacks(config.name, 'onError', error);
-        }
+        this.notifyConnectionError(config.name, error);
         this.notifyConnectionStateCallbacks(config.name, 'onReconnecting');
       });
 
@@ -645,6 +637,12 @@ class SignalRService {
     }
   }
 
+  private notifyConnectionError(hubName: string, error?: Error): void {
+    if (error) {
+      this.notifyConnectionStateCallbacks(hubName, 'onError', error);
+    }
+  }
+
   private notifyConnectionStateCallbacks(hubName: string, event: keyof SignalRConnectionStateCallbacks, error?: Error): void {
     this.connectionStateCallbacks.get(hubName)?.forEach((callbacks) => {
       try {

src/stores/signalr/signalr-store.ts

@@ -223,9 +223,12 @@ export const useSignalRStore = create<SignalRState>((set, get) => ({
           });
           set({ isUpdateHubConnected: true, error: null });
         });
+      }
 
-        // Set up connection state monitoring via the service's public API
-        // This ensures we properly track disconnections and reconnections
+      // Connection state monitoring re-registers on each connect: disconnect
+      // unregisters and nulls the handle, so guard on the handle rather than
+      // the one-time listener flag above.
+      if (!updateHubStateCallbackHandle) {
         updateHubStateCallbackHandle = signalRService.registerConnectionStateCallbacks(Env.CHANNEL_HUB_NAME, {
           onClose: () => {
             logger.info({