Merge pull request #256 from henriquemoody/not-shortcut

Fix wrong behavior when calling `not()` rule

Author: wesleyvicthor

library/Validator.php

@@ -146,8 +146,8 @@ public static function buildRule($ruleSpec, $arguments = array())
      */
     public function __call($method, $arguments)
     {
-        if ('not' === $method) {
-            return $arguments ? static::buildRule($method, $arguments) : new Rules\Not($this);
+        if ('not' === $method && empty($arguments)) {
+            return new static(new Rules\Not($this));
         }
 
         return $this->addRule(static::buildRule($method, $arguments));

tests/library/Respect/Validation/ValidatorTest.php

@@ -90,5 +90,24 @@ public function testKeysAsValidatorNames()
     \-"" must be a valid date', $e->getFullMessage());
         }
     }
-}
 
+    /**
+     * Regression test #174.
+     */
+    public function testShouldReturnANewValidatorInstanceWhenTheNotRuleIsCalledWithoutAnyArgument()
+    {
+        $validator = new Validator();
+
+        $this->assertInstanceOf('Respect\Validation\Validator', $validator->not());
+    }
+
+    /**
+     * Regression test #174.
+     */
+    public function testShouldReturnValidatorInstanceWhenTheNotRuleIsCalledWithArguments()
+    {
+        $validator = new Validator();
+
+        $this->assertSame($validator, $validator->not($validator->notEmpty()));
+    }
+}