Achievement type (Missable/Progression/WinCondition) always deserializes to null

[RobZombie9043]

Summary

Achievement.type comes back null on every achievement, for every game, through both endpoints that expose it — GetGameInfoAndUserProgress and GetGameExtended — but for two different reasons. Confirmed on 2.0.0 (also present on main as of this writing).

Bug 1: GetGameInfoAndUserProgress.Response.Achievement.type

// src/main/kotlin/org/retroachivements/api/data/pojo/game/GetGameInfoAndUserProgress.kt
@SerializedName("type")
val type: String?,

The live API_GetGameInfoAndUserProgress.php response does not include a type key on achievement objects at all, regardless of the a (includeUserAward) parameter. Every other field in this class deserializes correctly; only type is consistently absent/null.

Bug 2: GetGameExtended.Response.Achievement.type

// src/main/kotlin/org/retroachivements/api/data/pojo/game/GetGameExtended.kt
@SerializedName("Type")
val type: String

This one's the opposite problem: the live API_GetGameExtended.php response does include the data, but under a lowercase type key, not Type. Since Gson's field matching is case-sensitive, this annotation never matches and the field deserializes to null even though the data is present.

Confirmed via a raw (unparsed) response body for a classified achievement:

"...memAddr":"cd45f986c5bc8e43db4008d642d73140","type":"progression"},"..."

i.e. the key genuinely is lowercase type in the live payload, matching what GetGameInfoAndUserProgress's class already (correctly, per Bug 1's evidence) expects — GetGameExtended's annotation is the one that's wrong.

Suggested fix

• GetGameInfoAndUserProgress.Response.Achievement.type: investigate whether this endpoint can return type at all (perhaps behind a different/undocumented parameter), or document that it never does.
• GetGameExtended.Response.Achievement.type: change @SerializedName("Type") to @SerializedName("type") to match the live API.

Repro

Any authenticated getGameExtended(gameId) call for a game with at least one classified achievement (e.g. a Missable-tagged achievement) will show type == null on that achievement in the deserialized response, despite the RA website and the raw JSON both showing a real classification.

P.S. raised this as a Q&A as the Issues workflow to Report a bug is not working.

[hoangperry]

Confirming both findings against the live API and the codebase — your diagnosis is exactly right, and they're independently fixable:

• Bug 2 is a one-character-class fix: GetGameExtended's annotation says @SerializedName("Type") while the live payload key is lowercase type, and Gson matches case-sensitively — so the data arrives and is thrown away. Changing the annotation to "type" fixes it outright. That's a clean, small PR if you're up for it (the checkbox culture here suggests maintainers would take it); the test fixture in GetGameExtendedTest presumably also carries the uppercase key, so it needs the same touch.
• Bug 1 can't be fixed client-side: if API_GetGameInfoAndUserProgress.php genuinely never emits type on achievement objects, the Kotlin field is correctly nullable and will stay null until the upstream web API adds the key. Worth filing against the RetroAchievements API repo (RetroAchievements/RAWeb) instead — the schema divergence between the two endpoints is on their side.

Workaround until both land, if you need type today: fetch the game's achievements via GetGameExtended (with the annotation fix, or by post-processing the raw JSON) and join them by achievement ID onto the GetGameInfoAndUserProgress results — IDs are stable across both endpoints, so a Map<Long, String> of id→type built from one call patches the other cleanly.

[wescopeland]

Either of your Claudes are welcome to open a PR with a fix.