Make citation chips resolve reliably with reference fallbacks

Author: owenisas

backend/agent.py

@@ -1338,20 +1338,40 @@ def _build_content_nodes(created_main_block, tool_results=None):
             nodes.append({"type": "keyTerms", "terms": terms})
 
     refs = created_main_block.get("references")
+    items = []
     if isinstance(refs, list) and refs:
-        items = []
         for i, r in enumerate(refs):
             if isinstance(r, dict) and r.get("text"):
                 item = {
-                    "id": f"ref-{i}",
+                    "id": f"ref-{i + 1}",
                     "label": str(i + 1),
                     "text": str(r["text"]),
                 }
                 if r.get("url"):
                     item["url"] = str(r["url"])
                 items.append(item)
-        if items:
-            nodes.append({"type": "references", "items": items})
+
+    # Fallback: when OpenAI-style citation tokens are present in content but
+    # structured references were not returned, still generate placeholder
+    # entries so inline chips can scroll somewhere meaningful.
+    if not items:
+        seen_refs = set()
+        for m in _re.finditer(r"turn\d+search(\d+)", content, flags=_re.IGNORECASE):
+            try:
+                one_based = int(m.group(1)) + 1
+            except Exception:
+                continue
+            if one_based <= 0 or one_based in seen_refs:
+                continue
+            seen_refs.add(one_based)
+            items.append({
+                "id": f"ref-{one_based}",
+                "label": str(one_based),
+                "text": f"Web source #{one_based} (details unavailable in this response metadata).",
+            })
+
+    if items:
+        nodes.append({"type": "references", "items": items})
 
     quiz = created_main_block.get("quiz_questions")
     if isinstance(quiz, list) and quiz:

frontend/src/components/ui/RichText.tsx

@@ -383,6 +383,38 @@ function renderInline(text: string, variant: Variant, COLORS: ThemeColors, VS: R
   const nodes: React.ReactNode[] = []
   const codeFontSize = VS[variant].code.fontSize
 
+  const scrollToCitationTarget = (ids: number[]): boolean => {
+    if (typeof document === "undefined") return false
+
+    const candidates: string[] = []
+    if (ids.length > 1) candidates.push("references")
+    for (const id of ids) {
+      if (Number.isFinite(id) && id > 0) {
+        candidates.push(`ref-${id}`)
+        if (id - 1 >= 0) candidates.push(`ref-${id - 1}`) // backward-compat for old ref-0 IDs
+      }
+    }
+    candidates.push("references")
+
+    const seen = new Set<string>()
+    for (const c of candidates) {
+      if (!c || seen.has(c)) continue
+      seen.add(c)
+      const el = document.getElementById(c)
+      if (el) {
+        el.scrollIntoView({ behavior: "smooth", block: "start" })
+        return true
+      }
+    }
+
+    const byAria = document.querySelector('nav[aria-label="References"]') as HTMLElement | null
+    if (byAria) {
+      byAria.scrollIntoView({ behavior: "smooth", block: "start" })
+      return true
+    }
+    return false
+  }
+
   let cursor = 0
   let key = 0
 
@@ -429,16 +461,19 @@ function renderInline(text: string, variant: Variant, COLORS: ThemeColors, VS: R
       const token = parseOpenAICitationToken(text, cursor)
       if (token) {
         const citationText = token.ids.length ? `[${token.ids.join(",")}]` : "[source]"
-        const isSingle = token.ids.length === 1
-        const targetId = isSingle ? `ref-${token.ids[0]}` : "references"
         const canScroll = token.ids.length > 0
 
         if (canScroll) {
           nodes.push(
             <button
               key={`cite-openai-${key++}`}
               type="button"
-              onClick={() => document.getElementById(targetId)?.scrollIntoView({ behavior: "smooth", block: "start" })}
+              onClick={() => {
+                const ok = scrollToCitationTarget(token.ids)
+                if (!ok && typeof window !== "undefined") {
+                  window.alert("No reference details are attached to this response.")
+                }
+              }}
               style={{
                 font: "inherit",
                 fontSize: "0.7em",
@@ -526,13 +561,20 @@ function renderInline(text: string, variant: Variant, COLORS: ThemeColors, VS: R
         const isCitation = /^\d+([,\-\s]\d+)*$/.test(inner.trim()) && text[labelEnd + 1] !== "("
         if (isCitation) {
           const trimmed = inner.trim()
-          const isSingle = /^\d+$/.test(trimmed)
-          const targetId = isSingle ? `ref-${trimmed}` : "references"
+          const ids = trimmed
+            .split(/[,\-\s]+/)
+            .map((v) => Number(v))
+            .filter((v) => Number.isFinite(v) && v > 0)
           nodes.push(
             <button
               key={`cite-${key++}`}
               type="button"
-              onClick={() => document.getElementById(targetId)?.scrollIntoView({ behavior: "smooth", block: "start" })}
+              onClick={() => {
+                const ok = scrollToCitationTarget(ids)
+                if (!ok && typeof window !== "undefined") {
+                  window.alert("No reference details are attached to this response.")
+                }
+              }}
               style={{
                 font: "inherit",
                 fontSize: "0.7em",

frontend/src/lib/blockSession.ts

@@ -236,7 +236,7 @@ function buildContentNodesFromMetadata(
           const items = (node.items as Record<string, unknown>[])
             .filter((r) => typeof r.text === "string")
             .map((r, i) => ({
-              id: String(r.id ?? `ref-${i}`),
+              id: String(r.id ?? `ref-${i + 1}`),
               label: String(r.label ?? i + 1),
               text: String(r.text),
               ...(typeof r.url === "string" && r.url ? { url: r.url } : {}),