Add retry mechanism to purchases integration tests #3024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
requested changes
Jan 16, 2026
Contributor
fire-at-will
left a comment
fire-at-will
left a comment
There was a problem hiding this comment.
Looks good! I think I found one bug that we should address before shipping, but looks good otherwise!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
=======================================
Coverage 79.13% 79.13%
=======================================
Files 341 341
Lines 13557 13557
Branches 1824 1824
=======================================
Hits 10728 10728
Misses 2073 2073
Partials 756 756 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fire-at-will
approved these changes
Jan 16, 2026
Contributor
fire-at-will
left a comment
fire-at-will
left a comment
There was a problem hiding this comment.
Manually tested the retry logic and it works as expected in both the passing and failure cases 👍
Looks good! Will merge when CI is green again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is some flakyness in our purchases integration tests that we want to address... But for now until we have more time, we can do a couple retries before notifying anything is wrong.