Added options to pass through to sassc.

Detecting errors in compilation and outputting them, setting failure exit code if necessary.

Author: NiallSmyth

src/CompileScssCommand.php

@@ -21,6 +21,7 @@
 use Rhubarb\Crown\String\StringTools;
 use Rhubarb\Custard\Command\CustardCommand;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class CompileScssCommand extends CustardCommand
@@ -29,6 +30,13 @@ public function __construct()
     {
         parent::__construct('compile:scss');
 
+        $this->addOption('style', 's', InputOption::VALUE_REQUIRED, 'Output style. Can be: nested, compressed.', 'compressed');
+        $this->addOption('line-numbers', 'l', InputOption::VALUE_NONE, 'Emit comments showing original line numbers.');
+        $this->addOption('import-path', 'i', InputOption::VALUE_REQUIRED, 'Set Sass import path.');
+        $this->addOption('sourcemap', 'm', InputOption::VALUE_NONE, 'Emit source map.');
+        $this->addOption('omit-map-comment', 'M', InputOption::VALUE_NONE, 'Omits the source map url comment.');
+        $this->addOption('precision', 'p', InputOption::VALUE_REQUIRED, 'Set the precision for numbers.');
+
         $this->addArgument('input', null, 'File or directory to compile');
         $this->addArgument('output', null, 'File or directory to output to');
     }
@@ -46,7 +54,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         if (!file_exists($inputPath)) {
             $this->writeNormal('The input path specified does not exist.', true);
-            return;
+            return 1;
         }
 
         $multiple = false;
@@ -58,7 +66,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
             if (!count($scssFiles)) {
                 $this->writeNormal('The input directory does not contain any .css files.', true);
-                return;
+                return 1;
             }
         } else {
             $scssFiles = [$inputPath];
@@ -73,15 +81,32 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         if (!file_exists($outputPath)) {
             $this->writeNormal('The output path specified does not exist.', true);
-            return;
+            return 1;
         }
 
         if ($multiple && !is_dir($outputPath)) {
             $this->writeNormal('The input path was a directory so output path must also be a directory.', true);
-            return;
+            return 1;
+        }
+
+        return $this->compileScssFiles($scssFiles, $multiple, $outputPath);
+    }
+
+    protected function getOptionsForSassC()
+    {
+        $allowedOptions = array_flip(['style', 'line-numbers', 'import-path', 'sourcemap', 'omit-map-comment', 'precision']);
+        $specifiedOptions = array_intersect_key($this->input->getOptions(), $allowedOptions);
+
+        $options = [];
+        foreach ($specifiedOptions as $name => $value) {
+            if ($value === true) {
+                $options[] = "--$name";
+            } elseif (is_string($value)) {
+                $options[] = "--$name $value";
+            }
         }
 
-        $this->compileScssFiles($scssFiles, $multiple, $outputPath);
+        return implode(' ', $options);
     }
 
     /**
@@ -105,14 +130,17 @@ protected function scanDirectoryForScssFiles($directoryPath)
      * @param string[] $scssFiles
      * @param bool $inputIsDirectory
      * @param string $outputPath
+     * @return int Status code
      */
     protected function compileScssFiles($scssFiles, $inputIsDirectory, $outputPath)
     {
-        $cssFilePath = '';
+        $cssFilePath = $outputPath;
         if (!$inputIsDirectory && is_dir($outputPath)) {
             $cssFilePath = $outputPath . '/' . pathinfo($scssFiles[0], PATHINFO_FILENAME) . '.css';
         }
 
+        $status = 0;
+
         foreach ($scssFiles as $scssFilePath) {
             if ($inputIsDirectory) {
                 $cssFilePath = $outputPath . '/' . pathinfo($scssFilePath, PATHINFO_FILENAME) . '.css';
@@ -126,10 +154,26 @@ protected function compileScssFiles($scssFiles, $inputIsDirectory, $outputPath)
                 $exe = 'sassc';
             }
 
-            exec(VENDOR_DIR . '/eslider/sasscb/dist/' . $exe . ' ' . $scssFilePath . ' ' . $cssFilePath, $cliOutput);
+            exec(VENDOR_DIR . "/eslider/sasscb/dist/$exe {$this->getOptionsForSassC()} $scssFilePath $cssFilePath 2>&1", $cliOutput, $returnStatus);
+
+            $cliOutput = trim(implode("\n", $cliOutput));
+            if ($returnStatus) {
+                $this->writeNormal("<error>Compiling $scssFilePath failed</error>", true);
+                if ($cliOutput) {
+                    $this->writeNormal("<comment>$cliOutput</comment>", true);
+                }
+            } else {
+                if ($cliOutput) {
+                    $this->writeVerbose($cliOutput, true);
+                }
+                $this->writeNormal("<info>$scssFilePath compiled to $cssFilePath</info>", true);
+            }
 
-            $this->writeVerbose(implode("\n", $cliOutput), true);
-            $this->writeNormal($scssFilePath . ' compiled to ' . $cssFilePath, true);
+            if ($returnStatus) {
+                $status = $returnStatus;
+            }
         }
+
+        return $status;
     }
 }