Adding ProcessID to the BackgoundTask table

Fixing issue on BackgroundTask where the function setShellArguments was being called with no arguments which caused the script to fail with a warning

Author: Michael Miscampbell

CHANGELOG.md

@@ -5,6 +5,11 @@
 * TODO:     Windows support
 * TODO:     Restore PhpIdeConfig setting to allow debugging of running background tasks
 
+### 1.1.2
+
+* FIXED:    Fixed issue that caused the executing script to fail 
+* ADDED:    Added the ProcessID that is currently being ran to the Background Task table
+
 ### 1.1.1
 * UPDATED:  rhubarb_app environment setting support to allow background tasks to work in new environment
 

src/Models/BackgroundTaskStatus.php

@@ -19,10 +19,12 @@
 namespace Rhubarb\Scaffolds\BackgroundTasks\Models;
 
 use Rhubarb\Crown\Exceptions\RhubarbException;
+use Rhubarb\Scaffolds\BackgroundTasks\BackgroundTask;
 use Rhubarb\Stem\Models\Model;
 use Rhubarb\Stem\Repositories\MySql\Schema\Columns\MySqlEnumColumn;
 use Rhubarb\Stem\Schema\Columns\AutoIncrementColumn;
 use Rhubarb\Stem\Schema\Columns\DecimalColumn;
+use Rhubarb\Stem\Schema\Columns\IntegerColumn;
 use Rhubarb\Stem\Schema\Columns\JsonColumn;
 use Rhubarb\Stem\Schema\Columns\LongStringColumn;
 use Rhubarb\Stem\Schema\Columns\StringColumn;
@@ -37,6 +39,7 @@
  * @property string $TaskStatus The status of the task: Running, Complete or Failed
  * @property string $ExceptionDetails If the task failed, exception details will be contained here.
  * @property \stdClass $TaskSettings Settings to be passed to the task, stored as JSON
+ * @property int $ProcessID The PID for the background task process when it is executed
  */
 class BackgroundTaskStatus extends Model
 {
@@ -63,7 +66,8 @@ protected function createSchema()
             new DecimalColumn("PercentageComplete", 5, 2, 0),
             new StringColumn("Message", 200),
             new LongStringColumn("ExceptionDetails"),
-            new JsonColumn("TaskSettings", null, true)
+            new JsonColumn("TaskSettings", null, true),
+            new IntegerColumn("ProcessID")
         );
 
         return $schema;
@@ -78,10 +82,10 @@ protected function createSchema()
     public function start()
     {
         $class = $this->TaskClass;
+        /** @var BackgroundTask $task */
         $task = new $class();
 
         try {
-            $task->setShellArguments();
             $task->execute($this);
 
             $this->TaskStatus = "Complete";

src/Models/BackgroundTasksSolutionSchema.php

@@ -26,7 +26,7 @@ class BackgroundTasksSolutionSchema extends SolutionSchema
 {
     public function __construct()
     {
-        parent::__construct(0.12);
+        parent::__construct(0.13);
 
         $this->addModel("BackgroundTaskStatus", __NAMESPACE__ . '\BackgroundTaskStatus');
     }

src/Scripts/task-runner.php

@@ -18,6 +18,7 @@
 
 namespace Rhubarb\Scaffolds\BackgroundTasks\Scripts;
 
+use Rhubarb\Scaffolds\BackgroundTasks\BackgroundTask;
 use Rhubarb\Scaffolds\BackgroundTasks\Models\BackgroundTaskStatus;
 
 $taskClass = $argv[2];
@@ -36,6 +37,7 @@
 // See docs for more details on passing shell arguments.
 $additionalArguments = array_slice($argv, 4);
 
+/** @var BackgroundTask $taskClass */
 $taskClass::setShellArguments($additionalArguments);
 
 $pid = pcntl_fork();