Full functionality create/delete task scheduler task, create/delete firewall exception

Author: Rich Stephens

Tnfsd.NET/AppSettings.cs

@@ -0,0 +1,21 @@
+using System.IO;
+using Microsoft.Extensions.Configuration;
+
+namespace Tnfsd.NET
+{
+    public static class AppSettings
+    {
+        private static IConfigurationRoot _config;
+
+        static AppSettings()
+        {
+            var builder = new ConfigurationBuilder()
+                .SetBasePath(Directory.GetCurrentDirectory())
+                .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true);
+
+            _config = builder.Build();
+        }
+
+        public static string TNFSDownloadURL => _config["TNFSDownloadURL"];
+    }
+}

Tnfsd.NET/FirewallHelper.cs

@@ -1,90 +1,66 @@
 using System;
-using System.Diagnostics;
-using System.IO;
 
 namespace Tnfsd.NET
 {
     public static class FirewallManager
     {
-        public static void AddFirewallException(string exePath, string displayName)
+        public static void AddFirewallException(string exePath, string ruleName)
         {
-            if (string.IsNullOrWhiteSpace(exePath) || !File.Exists(exePath))
-                throw new FileNotFoundException("Executable not found for firewall exception.");
+            Type fwMgrType = Type.GetTypeFromProgID("HNetCfg.FwMgr");
+            dynamic fwMgr = Activator.CreateInstance(fwMgrType);
 
-            // Don't do anything if the firewall rule already exists.
-            if (VerifyFirewallRuleExists(exePath))
-            {
-                return;
-            }
-
-            RunNetshCommand($"advfirewall firewall add rule name=\"{displayName}\" dir=in action=allow program=\"{exePath}\" enable=yes profile=private,public");
+            dynamic app = Activator.CreateInstance(Type.GetTypeFromProgID("HNetCfg.FwAuthorizedApplication"));
+            app.Name = ruleName;
+            app.ProcessImageFileName = exePath;
+            app.Enabled = true;
+            app.Scope = 0; // NET_FW_SCOPE_ALL
+            app.IpVersion = 2; // NET_FW_IP_VERSION_ANY
 
-            if (VerifyFirewallRuleExists(exePath))
+            // Add to authorized apps if not already present
+            var apps = fwMgr.LocalPolicy.CurrentProfile.AuthorizedApplications;
+            try
             {
-                System.Windows.Forms.MessageBox.Show($"Firewall rule successfully added for {Path.GetFileName(exePath)}.", "Firewall Rule Added", System.Windows.Forms.MessageBoxButtons.OK, System.Windows.Forms.MessageBoxIcon.Information);
+                apps.Add(app);
             }
-            else
+            catch
             {
-                System.Windows.Forms.MessageBox.Show($"Warning: Unable to verify the firewall rule for {Path.GetFileName(exePath)}.", "Verification Warning", System.Windows.Forms.MessageBoxButtons.OK, System.Windows.Forms.MessageBoxIcon.Warning);
+                // If already exists, ignore
             }
         }
 
         public static void RemoveFirewallException(string exePath)
         {
-            if (string.IsNullOrWhiteSpace(exePath)) return;
-
-            // Don't do anything if the firewall rule is doesn't exist
-            if (!VerifyFirewallRuleExists(exePath))
-            {
-                return;
-            }
-
-            RunNetshCommand($"advfirewall firewall delete rule program=\"{exePath}\"");
+            Type fwMgrType = Type.GetTypeFromProgID("HNetCfg.FwMgr");
+            dynamic fwMgr = Activator.CreateInstance(fwMgrType);
+            var apps = fwMgr.LocalPolicy.CurrentProfile.AuthorizedApplications;
 
-            if (!VerifyFirewallRuleExists(exePath))
+            try
             {
-                System.Windows.Forms.MessageBox.Show($"Firewall rule successfully removed for {Path.GetFileName(exePath)}.", "Firewall Rule Removed", System.Windows.Forms.MessageBoxButtons.OK, System.Windows.Forms.MessageBoxIcon.Information);
+                apps.Remove(exePath);
             }
-            else
+            catch
             {
-                System.Windows.Forms.MessageBox.Show($"Warning: Firewall rule may still exist for {Path.GetFileName(exePath)}.", "Verification Warning", System.Windows.Forms.MessageBoxButtons.OK, System.Windows.Forms.MessageBoxIcon.Warning);
+                // Ignore if not found
             }
         }
 
-        private static bool VerifyFirewallRuleExists(string exePath)
+        public static bool FirewallExceptionExists(string ruleName)
         {
-            try
-            {
-                Process process = new Process();
-                process.StartInfo.FileName = "netsh";
-                process.StartInfo.Arguments = $"advfirewall firewall show rule name=all | findstr /I \"{exePath}\"";
-                process.StartInfo.RedirectStandardOutput = true;
-                process.StartInfo.RedirectStandardError = true;
-                process.StartInfo.UseShellExecute = false;
-                process.StartInfo.CreateNoWindow = true;
-                process.Start();
-                string output = process.StandardOutput.ReadToEnd();
-                process.WaitForExit();
+            Type fwMgrType = Type.GetTypeFromProgID("HNetCfg.FwMgr");
+            dynamic fwMgr = Activator.CreateInstance(fwMgrType);
+            var apps = fwMgr.LocalPolicy.CurrentProfile.AuthorizedApplications;
 
-                return output.Contains(exePath, StringComparison.OrdinalIgnoreCase);
-            }
-            catch
+            foreach (dynamic app in apps)
             {
-                return false;
+                if (app.Name != null &&
+                    app.Name.Equals(ruleName, StringComparison.OrdinalIgnoreCase))
+                {
+                    return true;
+                }
             }
-        }
 
-        private static void RunNetshCommand(string arguments)
-        {
-            Process process = new Process();
-            process.StartInfo.FileName = "netsh";
-            process.StartInfo.Arguments = arguments;
-            process.StartInfo.RedirectStandardOutput = true;
-            process.StartInfo.RedirectStandardError = true;
-            process.StartInfo.UseShellExecute = false;
-            process.StartInfo.CreateNoWindow = true;
-            process.Start();
-            process.WaitForExit();
+            return false;
         }
     }
 }
+