Background
Discovered while implementing the devkit-baseline PR (#8): hibana's test suite has 7 failing tests on main of v1.3.0:
addLanguageAlternate - adds translation as original FAILED (0ms)
addLanguageAlternate - adds translation as alternate FAILED (0ms)
languageAlternatesSchema - links pages by ID FAILED (0ms)
languageAlternatesSchema - handles multiple schema fields FAILED (0ms)
markdownMetadata - extracts excerpt from content FAILED (2ms)
markdownMetadata - calculates elapsed days FAILED (0ms)
markdownMetadata - respects custom excerpt marker FAILED (0ms)
FAILED | 13 passed | 7 failed
All seven fail with AssertionError: Values are not equal — value mismatches, not crashes.
Likely cause
Recent upgrades. The user confirmed they "did some upgrades in hibana" recently and were not aware tests were failing. The two affected files are:
preprocessors/__tests__/language_alternates_schema.test.ts (4 failing)preprocessors/__tests__/markdown_metadata.test.ts (3 failing)
Both files test preprocessors — the recent upgrades probably changed expected output shape (Lume API drift, schema field changes, frontmatter handling) and the tests' expected values weren't updated to match.
Why this isn't in the baseline-adoption PR
The baseline PR adds CI but deliberately does not run deno test in the CI workflow, so it can land without being blocked by these pre-existing failures. Once these are fixed, deno task test should be added to ci.yml (it's currently fmt + lint + check only — see the comment in .github/workflows/ci.yml).
Acceptance
Related
Background
Discovered while implementing the devkit-baseline PR (#8): hibana's test suite has 7 failing tests on
mainof v1.3.0:All seven fail with
AssertionError: Values are not equal— value mismatches, not crashes.Likely cause
Recent upgrades. The user confirmed they "did some upgrades in hibana" recently and were not aware tests were failing. The two affected files are:
preprocessors/__tests__/language_alternates_schema.test.ts(4 failing)preprocessors/__tests__/markdown_metadata.test.ts(3 failing)Both files test preprocessors — the recent upgrades probably changed expected output shape (Lume API drift, schema field changes, frontmatter handling) and the tests' expected values weren't updated to match.
Why this isn't in the baseline-adoption PR
The baseline PR adds CI but deliberately does not run
deno testin the CI workflow, so it can land without being blocked by these pre-existing failures. Once these are fixed,deno task testshould be added toci.yml(it's currentlyfmt + lint + checkonly — see the comment in.github/workflows/ci.yml).Acceptance
deno test --allow-read --unstable-temporaldeno task teststep to.github/workflows/ci.yml(re-enable the test gate)Related