issue fixes

Author: jaberjaber23

Cargo.lock

@@ -18,7 +18,7 @@ members = [
 ]
 
 [workspace.package]
-version = "0.3.27"
+version = "0.3.28"
 edition = "2021"
 license = "Apache-2.0 OR MIT"
 repository = "https://github.com/RightNow-AI/openfang"

Cargo.toml

@@ -435,7 +435,11 @@ impl ChannelAdapter for BlueskyAdapter {
                     service_url
                 );
                 if let Some(ref seen) = last_seen_at {
-                    url.push_str(&format!("&seenAt={}", seen));
+                    let encoded: String = url::form_urlencoded::Serializer::new(String::new())
+                        .append_pair("seenAt", seen)
+                        .finish();
+                    url.push('&');
+                    url.push_str(&encoded);
                 }
 
                 let resp = match client.get(&url).bearer_auth(&token).send().await {

crates/openfang-channels/src/bluesky.rs

@@ -1163,6 +1163,10 @@ fn cmd_init(quick: bool) {
 
     if quick {
         cmd_init_quick(&openfang_dir);
+    } else if !std::io::IsTerminal::is_terminal(&std::io::stdout()) {
+        ui::hint("Non-interactive terminal detected — running in quick mode");
+        ui::hint("For the interactive wizard, run: openfang init (in a terminal)");
+        cmd_init_quick(&openfang_dir);
     } else {
         cmd_init_interactive(&openfang_dir);
     }

crates/openfang-cli/src/main.rs

@@ -216,8 +216,13 @@ fn read_message(reader: &mut impl BufRead) -> io::Result<Option<Value>> {
 /// Write a Content-Length framed JSON-RPC response to the writer.
 fn write_message(writer: &mut impl Write, msg: &Value) {
     let body = serde_json::to_string(msg).unwrap_or_default();
-    let _ = write!(writer, "Content-Length: {}\r\n\r\n{}", body.len(), body);
-    let _ = writer.flush();
+    if let Err(e) = write!(writer, "Content-Length: {}\r\n\r\n{}", body.len(), body) {
+        eprintln!("MCP write error: {e}");
+        return;
+    }
+    if let Err(e) = writer.flush() {
+        eprintln!("MCP flush error: {e}");
+    }
 }
 
 /// Handle a JSON-RPC message and return an optional response.
@@ -234,7 +239,7 @@ fn handle_message(backend: &McpBackend, msg: &Value) -> Option<Value> {
                 },
                 "serverInfo": {
                     "name": "openfang",
-                    "version": "0.1.0"
+                    "version": env!("CARGO_PKG_VERSION")
                 }
             });
             Some(jsonrpc_response(id?, result))

crates/openfang-cli/src/mcp.rs

@@ -17,7 +17,7 @@ tools = [
 key = "python3"
 label = "Python 3 must be installed"
 requirement_type = "binary"
-check_value = "python"
+check_value = "python3"
 description = "Python 3 is required to run Playwright, the browser automation library that powers this hand."
 
 [requires.install]

crates/openfang-hands/bundled/browser/HAND.toml

@@ -311,8 +311,15 @@ impl Default for HandRegistry {
 fn check_requirement(req: &HandRequirement) -> bool {
     match req.requirement_type {
         RequirementType::Binary => {
-            // Check if binary exists on PATH
-            which_binary(&req.check_value)
+            // Check if binary exists on PATH.
+            // For python3, also try "python" (Windows ships python not python3).
+            if which_binary(&req.check_value) {
+                return true;
+            }
+            if req.check_value == "python3" {
+                return which_binary("python");
+            }
+            false
         }
         RequirementType::EnvVar | RequirementType::ApiKey => {
             // Check if env var is set and non-empty

crates/openfang-hands/src/registry.rs

@@ -791,7 +791,8 @@ impl OpenFangKernel {
             if let Some(ref provider) = config.memory.embedding_provider {
                 // Explicit config takes priority — use the configured embedding model
                 let api_key_env = config.memory.embedding_api_key_env.as_deref().unwrap_or("");
-                match create_embedding_driver(provider, configured_model, api_key_env) {
+                let custom_url = config.provider_urls.get(provider.as_str()).map(|s| s.as_str());
+                match create_embedding_driver(provider, configured_model, api_key_env, custom_url) {
                     Ok(d) => {
                         info!(provider = %provider, model = %configured_model, "Embedding driver configured from memory config");
                         Some(Arc::from(d))
@@ -807,7 +808,7 @@ impl OpenFangKernel {
                 } else {
                     configured_model.as_str()
                 };
-                match create_embedding_driver("openai", model, "OPENAI_API_KEY") {
+                match create_embedding_driver("openai", model, "OPENAI_API_KEY", None) {
                     Ok(d) => {
                         info!("Embedding driver auto-detected: OpenAI");
                         Some(Arc::from(d))
@@ -824,7 +825,8 @@ impl OpenFangKernel {
                 } else {
                     configured_model.as_str()
                 };
-                match create_embedding_driver("ollama", model, "") {
+                let ollama_url = config.provider_urls.get("ollama").map(|s| s.as_str());
+                match create_embedding_driver("ollama", model, "", ollama_url) {
                     Ok(d) => {
                         info!("Embedding driver auto-detected: Ollama (local)");
                         Some(Arc::from(d))
@@ -2342,6 +2344,9 @@ impl OpenFangKernel {
             .update_session_id(agent_id, new_session.id)
             .map_err(KernelError::OpenFang)?;
 
+        // Reset quota tracking so /new clears "token quota exceeded"
+        self.scheduler.reset_usage(agent_id);
+
         info!(agent_id = %agent_id, "Session reset (summary saved to memory)");
         Ok(())
     }

crates/openfang-kernel/src/kernel.rs

@@ -100,6 +100,15 @@ impl AgentScheduler {
         Ok(())
     }
 
+    /// Reset usage tracking for an agent (e.g. on session reset).
+    pub fn reset_usage(&self, agent_id: AgentId) {
+        if let Some(mut tracker) = self.usage.get_mut(&agent_id) {
+            tracker.total_tokens = 0;
+            tracker.tool_calls = 0;
+            tracker.window_start = Instant::now();
+        }
+    }
+
     /// Abort an agent's active task.
     pub fn abort_task(&self, agent_id: AgentId) {
         if let Some((_, handle)) = self.tasks.remove(&agent_id) {

crates/openfang-kernel/src/scheduler.rs

@@ -179,27 +179,31 @@ pub fn create_embedding_driver(
     provider: &str,
     model: &str,
     api_key_env: &str,
+    custom_base_url: Option<&str>,
 ) -> Result<Box<dyn EmbeddingDriver + Send + Sync>, EmbeddingError> {
     let api_key = if api_key_env.is_empty() {
         String::new()
     } else {
         std::env::var(api_key_env).unwrap_or_default()
     };
 
-    let base_url = match provider {
-        "openai" => OPENAI_BASE_URL.to_string(),
-        "groq" => GROQ_BASE_URL.to_string(),
-        "together" => TOGETHER_BASE_URL.to_string(),
-        "fireworks" => FIREWORKS_BASE_URL.to_string(),
-        "mistral" => MISTRAL_BASE_URL.to_string(),
-        "ollama" => OLLAMA_BASE_URL.to_string(),
-        "vllm" => VLLM_BASE_URL.to_string(),
-        "lmstudio" => LMSTUDIO_BASE_URL.to_string(),
-        other => {
-            warn!("Unknown embedding provider '{other}', using OpenAI-compatible format");
-            format!("https://{other}/v1")
-        }
-    };
+    let base_url = custom_base_url
+        .filter(|u| !u.is_empty())
+        .map(|u| u.to_string())
+        .unwrap_or_else(|| match provider {
+            "openai" => OPENAI_BASE_URL.to_string(),
+            "groq" => GROQ_BASE_URL.to_string(),
+            "together" => TOGETHER_BASE_URL.to_string(),
+            "fireworks" => FIREWORKS_BASE_URL.to_string(),
+            "mistral" => MISTRAL_BASE_URL.to_string(),
+            "ollama" => OLLAMA_BASE_URL.to_string(),
+            "vllm" => VLLM_BASE_URL.to_string(),
+            "lmstudio" => LMSTUDIO_BASE_URL.to_string(),
+            other => {
+                warn!("Unknown embedding provider '{other}', using OpenAI-compatible format");
+                format!("https://{other}/v1")
+            }
+        });
 
     // SECURITY: Warn when embedding requests will be sent to an external API
     let is_local = base_url.contains("localhost")
@@ -351,7 +355,7 @@ mod tests {
     #[test]
     fn test_create_embedding_driver_ollama() {
         // Should succeed even without API key (ollama is local)
-        let driver = create_embedding_driver("ollama", "all-MiniLM-L6-v2", "");
+        let driver = create_embedding_driver("ollama", "all-MiniLM-L6-v2", "", None);
         assert!(driver.is_ok());
         assert_eq!(driver.unwrap().dimensions(), 384);
     }