fix(schema): heal stale component-level 'root' op de component-catalog (#120)

De migratie _migrate_v2_to_v2_1 (root: true -> deployment-level
root-component) scande alleen deployment-component-refs, niet de
project-level component-catalog, en was version-gated. Bestanden die al
op schema-version 2.2 stonden met een achtergebleven `root:`-key op een
catalog-component faalden daardoor elke deploy op schemavalidatie
(components/0: Additional properties are not allowed ('root')).

Voegt _fixup_catalog_root toe, aangeroepen vanuit het onvoorwaardelijke
_fixup_v2_data, dat:
- `root` van catalog-componenten verwijdert ongeacht schema-version
- een echte root lift naar root-component op elke deployment die de
  component refereert en er nog geen heeft
- `root: false` simpelweg dropt

Werkt zo ook al-2.2-gestempelde bestanden bij op de eerstvolgende load.
Verwijdert daarnaast een stale docstring in router_wizard.py die nog
naar de oude root:true-conversie verwees.

Author: uittenbroekrobbert

operations-manager/python/opi/services/schema_migration.py

@@ -427,13 +427,59 @@ def _fixup_v2_data(project_data: dict[str, Any]) -> bool:
         if _fixup_flat_resources(entity):
             cleaned = True
 
+    # Strip stale root flags left on the project-level component catalog
+    if _fixup_catalog_root(project_data):
+        cleaned = True
+
     if cleaned:
         project_name = project_data.get("name", "unknown")
         logger.info(f"Cleaned up stale data in project '{project_name}'")
 
     return cleaned
 
 
+def _fixup_catalog_root(project_data: dict[str, Any]) -> bool:
+    """Strip stale component-level ``root`` flags from the top-level component catalog.
+
+    The original nice-url feature stored the root marker as ``root: true`` on
+    catalog components. The schema later moved this to deployment-level
+    ``root-component`` (see ``_migrate_v2_to_v2_1``), but that migration only
+    scans deployment component refs, not the project-level catalog, and it is
+    version-gated -- so files already stamped at the latest version keep the
+    stale catalog key and fail schema validation. This fixup runs
+    unconditionally to repair them.
+
+    For any catalog component still marked ``root: true``, the marker is lifted
+    to ``root-component`` on every deployment that references it and does not
+    already have one, then the ``root`` key is removed. ``root: false`` is
+    dropped outright.
+
+    Returns True if any cleanup was performed.
+    """
+    catalog = [c for c in project_data.get("components", []) if isinstance(c, dict)]
+    deployments = [d for d in project_data.get("deployments", []) if isinstance(d, dict)]
+    cleaned = False
+
+    for comp in catalog:
+        if "root" not in comp:
+            continue
+
+        is_root = comp.get("root") is True
+        comp_name = comp.get("name")
+        del comp["root"]
+        cleaned = True
+
+        if is_root and comp_name:
+            for dep in deployments:
+                if dep.get("root-component"):
+                    continue
+                refs = {r.get("reference") for r in dep.get("components", []) if isinstance(r, dict)}
+                if comp_name in refs:
+                    dep["root-component"] = comp_name
+
+    return cleaned
+
+
 def _fixup_flat_resources(entity: dict[str, Any]) -> bool:
     """Migrate old flat resource format to nested requests/limits structure.
 

operations-manager/python/opi/web/router_wizard.py

@@ -1157,7 +1157,9 @@ def _assemble_deployment(final_data: dict[str, Any]) -> None:
 
     - Sets ``name``, ``cluster``, ``namespace``, ``repository``
     - Builds ``components`` array from component names
-    - Converts ``root-component`` to ``root: true`` on the matching component
+
+    The root component is carried as deployment-level ``root-component`` and is
+    left untouched here (it is set during the domain step).
     """
     deployments = final_data.get("deployments", [{}])
     deployment = deployments[0] if deployments else {}

operations-manager/python/tests/test_fixup_v2_data.py

@@ -302,3 +302,82 @@ def test_upload_cleanup(self):
         assert comp["resources"]["limits"]["cpu"] == "1"
         assert comp["resources"]["limits"]["memory"] == "256Mi"
         assert comp["resources"]["requests"]["memory"] == "256Mi"
+
+
+# ---------------------------------------------------------------------------
+# _fixup_catalog_root: stale root flag on the top-level component catalog
+# ---------------------------------------------------------------------------
+
+
+class TestFixupCatalogRoot:
+    def test_strips_catalog_root_and_lifts_to_deployment(self):
+        """A catalog component marked root: true lifts to root-component on the
+        referencing deployment, and the stale catalog key is removed."""
+        data = {
+            "schema-version": 2.2,
+            "components": [{"name": "component-1", "root": True}],
+            "deployments": [
+                {"name": "main", "components": [{"reference": "component-1"}]},
+            ],
+        }
+        assert _fixup_v2_data(data) is True
+        assert "root" not in data["components"][0]
+        assert data["deployments"][0]["root-component"] == "component-1"
+
+    def test_strips_catalog_root_when_deployment_already_has_root_component(self):
+        """If the deployment already has root-component, it takes precedence and
+        the stale catalog flag is simply removed."""
+        data = {
+            "schema-version": 2.2,
+            "components": [{"name": "component-1", "root": True}],
+            "deployments": [
+                {
+                    "name": "main",
+                    "components": [{"reference": "component-1"}],
+                    "root-component": "component-1",
+                },
+            ],
+        }
+        assert _fixup_v2_data(data) is True
+        assert "root" not in data["components"][0]
+        assert data["deployments"][0]["root-component"] == "component-1"
+
+    def test_drops_root_false_without_lifting(self):
+        data = {
+            "schema-version": 2.2,
+            "components": [{"name": "component-1", "root": False}],
+            "deployments": [
+                {"name": "main", "components": [{"reference": "component-1"}]},
+            ],
+        }
+        assert _fixup_v2_data(data) is True
+        assert "root" not in data["components"][0]
+        assert "root-component" not in data["deployments"][0]
+
+    def test_runs_on_already_latest_version_via_migrate_to_latest(self):
+        """The bouwm-6gn case: a file already stamped 2.2 with a catalog root key
+        is still repaired (the version-gated _migrate_v2_to_v2_1 would skip it)."""
+        data = {
+            "schema-version": 2.2,
+            "components": [{"name": "component-1", "root": True}],
+            "deployments": [
+                {
+                    "name": "main",
+                    "components": [{"reference": "component-1"}],
+                    "root-component": "component-1",
+                },
+            ],
+        }
+        result, migrated = migrate_to_latest(data)
+        assert migrated is True
+        assert "root" not in result["components"][0]
+
+    def test_no_change_when_catalog_has_no_root(self):
+        data = {
+            "schema-version": 2.2,
+            "components": [{"name": "component-1"}],
+            "deployments": [
+                {"name": "main", "components": [{"reference": "component-1"}]},
+            ],
+        }
+        assert _fixup_v2_data(data) is False