fix: allow global options (--output, -p, etc.) after subcommands

Users expect `zad metrics overview --output json` to work, but Typer
only recognizes global options before the subcommand. Added a custom
TyperGroup that hoists global options to the front of the arg list
before parsing, so they work in any position.

Author: anneschuth

src/zad_cli/cli.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import typer
+from typer.core import TyperGroup
 
 from zad_cli import __version__
 from zad_cli.commands import (
@@ -21,7 +22,43 @@
 from zad_cli.commands.config_cmd import app as config_app
 from zad_cli.commands.open_cmd import app as open_app
 
+
+class _GlobalOptionsGroup(TyperGroup):
+    """Hoist global options to before the subcommand so they work in any position."""
+
+    _OPTS_WITH_VALUE = frozenset({"--output", "-o", "--api-key", "--api-url", "--project", "-p"})
+    _FLAGS = frozenset({"--no-wait", "--verbose", "-v"})
+
+    def parse_args(self, ctx, args):  # noqa: ANN001
+        global_args: list[str] = []
+        remaining: list[str] = []
+        i = 0
+        while i < len(args):
+            arg = args[i]
+            if arg == "--":
+                remaining.extend(args[i:])
+                break
+            elif "=" in arg and arg.split("=", 1)[0] in self._OPTS_WITH_VALUE:
+                global_args.append(arg)
+                i += 1
+            elif arg in self._OPTS_WITH_VALUE:
+                global_args.append(arg)
+                if i + 1 < len(args):
+                    global_args.append(args[i + 1])
+                    i += 2
+                else:
+                    i += 1
+            elif arg in self._FLAGS:
+                global_args.append(arg)
+                i += 1
+            else:
+                remaining.append(arg)
+                i += 1
+        return super().parse_args(ctx, global_args + remaining)
+
+
 app = typer.Typer(
+    cls=_GlobalOptionsGroup,
     help="CLI for ZAD (Zelfservice Applicatie Deployment).",
     no_args_is_help=True,
     rich_markup_mode="rich",

tests/test_cli.py

@@ -153,3 +153,44 @@ def test_all_subcommands_have_help():
     for cmd in subcommands:
         result = _run_help(cmd)
         assert result.returncode == 0, f"{cmd} --help failed: {result.stderr}"
+
+
+# --- Global options in any position ---
+
+_MINIMAL_ENV = {"PATH": "/usr/bin:/bin", "NO_COLOR": "1", "TERM": "dumb"}
+
+
+def test_global_option_after_subcommand():
+    """Global options like --output should work after the subcommand."""
+    result = subprocess.run(
+        [sys.executable, "-m", "zad_cli", "metrics", "overview", "--output", "json"],
+        capture_output=True,
+        text=True,
+        env=_MINIMAL_ENV,
+    )
+    err = _strip_ansi(result.stderr)
+    assert "No such option" not in err
+
+
+def test_global_option_equals_form():
+    """--output=json form should also work after the subcommand."""
+    result = subprocess.run(
+        [sys.executable, "-m", "zad_cli", "deployment", "list", "--output=yaml"],
+        capture_output=True,
+        text=True,
+        env=_MINIMAL_ENV,
+    )
+    err = _strip_ansi(result.stderr)
+    assert "No such option" not in err
+
+
+def test_global_flag_after_subcommand():
+    """Global flags like --verbose should work after the subcommand."""
+    result = subprocess.run(
+        [sys.executable, "-m", "zad_cli", "metrics", "overview", "--verbose"],
+        capture_output=True,
+        text=True,
+        env=_MINIMAL_ENV,
+    )
+    err = _strip_ansi(result.stderr)
+    assert "No such option" not in err