Fix minimum label width

GridBagLayout does not respect minimum size, only preferred size.
GridBagLayout also treats preferred size as the maximum size.
In order to set a minimum width, while allowing a label to grow if text
overflows, the only solution is to override getPreferredSize
dynamically.

Author: iqqu

src/main/java/com/rarchives/ripme/ui/MainWindow.java

@@ -67,17 +67,17 @@ public final class MainWindow implements Runnable, RipStatusHandler {
 
     private static JLabel statusLabel;
     private static final ProgressTextField currentlyRippingProgress = new ProgressTextField();
-    private static final JLabel pendingValue = new JLabel("0");
+    private static final JLabel pendingValue = new MinimumWidthLabel("1000", "0");
     private static final JLabel pendingLabel = new JLabel("Pending");
-    private static final JLabel activeValue = new JLabel("0");
+    private static final JLabel activeValue = new MinimumWidthLabel("1000", "0");
     private static final JLabel activeLabel = new JLabel("Active");
-    private static final JLabel completedValue = new JLabel("0");
+    private static final JLabel completedValue = new MinimumWidthLabel("1000", "0");
     private static final JLabel completedLabel = new JLabel("Completed");
-    private static final JLabel erroredValue = new JLabel("0");
+    private static final JLabel erroredValue = new MinimumWidthLabel("1000", "0");
     private static final JLabel erroredLabel = new JLabel("Errored");
-    private static final JLabel totalValue = new JLabel("0");
+    private static final JLabel totalValue = new MinimumWidthLabel("1000", "0");
     private static final JLabel totalLabel = new JLabel("Total");
-    private static final JLabel transferRateValue = new JLabel("0.00 B/s");
+    private static final JLabel transferRateValue = new MinimumWidthLabel("999.00 KiB/s", "0.00 B/s");
     private static final JLabel transferRateLabel = new JLabel("Speed");
     private static final JButton openButton = new JButton();
 
@@ -400,10 +400,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         pendingValue.setFont(monospaced);
         pendingValue.setHorizontalAlignment(JLabel.TRAILING);
         pendingValue.setBorder(valueLabelBorder);
-        pendingValue.setText("1000");
-        pendingValue.setPreferredSize(pendingValue.getPreferredSize());
-        pendingValue.setMinimumSize(pendingValue.getPreferredSize());
-        pendingValue.setText("0");
         gbc = new GridBagConstraints();
         gbc.gridx = 0;
         gbc.gridy = 0;
@@ -417,10 +413,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         activeValue.setFont(monospaced);
         activeValue.setHorizontalAlignment(JLabel.TRAILING);
         activeValue.setBorder(valueLabelBorder);
-        activeValue.setText("1000");
-        activeValue.setPreferredSize(activeValue.getPreferredSize());
-        activeValue.setMinimumSize(activeValue.getPreferredSize());
-        activeValue.setText("0");
         gbc = new GridBagConstraints();
         gbc.gridx = 0;
         gbc.gridy = 1;
@@ -434,10 +426,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         completedValue.setFont(monospaced);
         completedValue.setHorizontalAlignment(JLabel.TRAILING);
         completedValue.setBorder(valueLabelBorder);
-        completedValue.setText("1000");
-        completedValue.setPreferredSize(completedValue.getPreferredSize());
-        completedValue.setMinimumSize(completedValue.getPreferredSize());
-        completedValue.setText("0");
         gbc = new GridBagConstraints();
         gbc.gridx = 3;
         gbc.gridy = 0;
@@ -451,10 +439,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         erroredValue.setFont(monospaced);
         erroredValue.setHorizontalAlignment(JLabel.TRAILING);
         erroredValue.setBorder(valueLabelBorder);
-        erroredValue.setText("1000");
-        erroredValue.setPreferredSize(erroredValue.getPreferredSize());
-        erroredValue.setMinimumSize(erroredValue.getPreferredSize());
-        erroredValue.setText("0");
         gbc = new GridBagConstraints();
         gbc.gridx = 3;
         gbc.gridy = 1;
@@ -468,10 +452,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         totalValue.setFont(monospaced);
         totalValue.setHorizontalAlignment(JLabel.TRAILING);
         totalValue.setBorder(valueLabelBorder);
-        totalValue.setText("1000");
-        totalValue.setPreferredSize(totalValue.getPreferredSize());
-        totalValue.setMinimumSize(totalValue.getPreferredSize());
-        totalValue.setText("0");
         gbc = new GridBagConstraints();
         gbc.gridx = 6;
         gbc.gridy = 0;
@@ -485,11 +465,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         transferRateValue.setFont(monospaced);
         transferRateValue.setHorizontalAlignment(JLabel.TRAILING);
         transferRateValue.setBorder(valueLabelBorder);
-        transferRateValue.setText("999.00 KiB/s"); // Maximum width value
-        // Set preferred size to maximum width value
-        transferRateValue.setPreferredSize(transferRateValue.getPreferredSize());
-        transferRateValue.setMinimumSize(transferRateValue.getPreferredSize());
-        transferRateValue.setText("0 B/s"); // Restore default value
         gbc = new GridBagConstraints();
         gbc.gridx = 6;
         gbc.gridy = 1;
@@ -516,8 +491,6 @@ public void replace(FilterBypass fb, int offset, int length, String text, Attrib
         gbc.fill = GridBagConstraints.HORIZONTAL;
         statusDetailPanel.add(spacer2, gbc);
 
-        statusDetailPanel.setPreferredSize(new Dimension(350, statusDetailPanel.getPreferredSize().height));
-
         openButton.setVisible(false);
 
         gbc = new GridBagConstraints();

src/main/java/com/rarchives/ripme/ui/MinimumWidthLabel.java

@@ -0,0 +1,33 @@
+package com.rarchives.ripme.ui;
+
+import javax.swing.JLabel;
+import java.awt.Dimension;
+
+/**
+ * GridBagLayout does not respect minimum size, only preferred size.
+ * In order to set a minimum width, we need to override getPreferredSize.
+ */
+public class MinimumWidthLabel extends JLabel {
+    String minimumWidthText;
+
+    public MinimumWidthLabel(String minimumWidthText, String defaultText) {
+        this.minimumWidthText = minimumWidthText;
+        setText(defaultText);
+    }
+
+    @Override
+    public Dimension getPreferredSize() {
+        String text = getText();
+        Dimension preferredSize = super.getPreferredSize();
+        setText(minimumWidthText);
+        int minimumWidth = super.getPreferredSize().width;
+        // Hopefully GridBagLayout correctly handles maximum size and we don't need to clamp
+        preferredSize.width = Math.max(minimumWidth, preferredSize.width);
+        setText(text);
+        return preferredSize;
+    }
+
+    public void setMinimumWidthText(String minimumWidthText) {
+        this.minimumWidthText = minimumWidthText;
+    }
+}