Open
Description
- Ripme version: 1.7.68
- Java version: 1.8.0_181-8u181
- Operating system: Ubuntu 16.04
- Exact URL you were trying to rip when the problem occurred:
- Please include any additional information about how to reproduce the problem:
Expected Behavior
Ripme ends the current rip after finding 5 items it already downloaded (assuming history.end_rip_after_already_seen is set to 5)
Actual Behavior
Ripme only ends the current rip if remember.url_history is set to true. This is because history.end_rip_after_already_seen checks the alreadyDownloadedUrls
var and alreadyDownloadedUrls
is only incremented in the following if
// Don't re-add the url if it was downloaded in a previous rip
if (Utils.getConfigBoolean("remember.url_history", true) && !isThisATest()) {
if (hasDownloadedURL(url.toExternalForm())) {
sendUpdate(STATUS.DOWNLOAD_WARN, "Already downloaded " + url.toExternalForm());
alreadyDownloadedUrls += 1;
return false;
}
}
Another check should be added in DownloadFileThread.java. Something like
if (saveAs.exists() && !observer.tryResumeDownload()) {
alreadyDownloadedUrls += 1
}
Metadata
Metadata
Assignees
Labels
No labels