Skip to content

Not working with Node 10 #15

@Fumler

Description

@Fumler

Hello. Thank you for creating this package, it has been a big help for us. Been using this (in prod 😅) for a while.

After we updated to Node 10 it stopped working for outgoing requests, the express module still works, but httpClient does not.

  opentracing-auto:instrumentation:httpClient Patched +0ms
  opentracing-auto:instrument Instrumentation "httpClient" applied on module "http" { moduleVersion: undefined, supportedVersions: undefined } +53ms
  opentracing-auto:instrument Instrumentation "express" applied on module "express" { moduleVersion: '4.16.3', supportedVersions: [ '4.x' ] } +127ms
  opentracing-auto:instrumentation:expressError Patched +0ms
  opentracing-auto:instrument Instrumentation "expressError" applied on module "express" { moduleVersion: '4.16.3', supportedVersions: [ '4.x' ] } +1ms

And then when we get incoming requests:

opentracing-auto:cls Root span started +0ms
  opentracing-auto:instrumentation:express Operation started http_server { 'http.url': 'http://localhost:4000/', 'http.method': 'GET' } +33s

But on outgoing requests we get no logs of httpClient doing anything.

Any ideas?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions