fix(compshouldupdate): fix componentshouldupdate and remove componnentwillmount hooks

Author: solkimicreb

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-easy-state",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Easy State replaces React's setState with plain native JavaScript",
   "main": "dist/easyState.js",
   "module": "src/easyState.js",

src/easyState.js

@@ -1,4 +1,4 @@
-import { observable, observe, unobserve } from '@nx-js/observer-util'
+import { observable, observe } from '@nx-js/observer-util'
 import autoBind from './autoBind'
 
 const OBSERVED_RENDER = Symbol('observed render')
@@ -27,13 +27,20 @@ export default function easyStateHOC (WrappedComp) {
       return result
     }
 
-    componentWillUnmount () {
-      unobserve(this[OBSERVED_RENDER])
-      this[OBSERVED_RENDER] = undefined
-      super.componentWillUnmount && super.componentWillUnmount()
-    }
+    shouldComponentUpdate (nextProps) {
+      const { props } = this
+      const keys = Object.keys(props)
+      const nextKeys = Object.keys(nextProps)
+
+      if (keys.length !== nextKeys.length) {
+        return true
+      }
 
-    shouldComponentUpdate () {
+      for (let key of keys) {
+        if (props[key] !== nextProps[key]) {
+          return true
+        }
+      }
       return false
     }
   }

src/easyState.test.js

@@ -51,13 +51,6 @@ describe('easyState', () => {
     expect(observer.isObservable(comp.state)).to.be.true
   })
 
-  it('should overwrite shouldComponentUpdate with an always false method', () => {
-    const comp = new (easyState(TestComp))
-
-    expect(comp.shouldComponentUpdate).to.be.a('function')
-    expect(comp.shouldComponentUpdate()).to.be.false
-  })
-
   it('should overwrite the render method', () => {
     const comp = new (easyState(TestComp))
 

webpack.config.js

@@ -19,7 +19,7 @@ module.exports = {
         use: {
           loader: 'babel-loader',
           options: {
-            presets: ['react', 'es2015', 'stage-0'],
+            presets: ['react', 'stage-0'],
             plugins: ['transform-decorators-legacy']
           }
         }
@@ -30,7 +30,7 @@ module.exports = {
         use: {
           loader: 'babel-loader',
           options: {
-            presets: ['es2015', 'stage-0']
+            presets: ['stage-0']
           }
         }
       }