Skip to content

Commit 9d3e1a4

Browse files
norbertkovacs95rolandszoke
authored andcommitted
test(staticprops): replace expected error messages
1 parent 423d5e6 commit 9d3e1a4

File tree

3 files changed

+29
-22
lines changed

3 files changed

+29
-22
lines changed

__tests__/staticProps.test.jsx

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,18 @@ describe('static props', () => {
5050
name: PropTypes.string.isRequired,
5151
};
5252

53-
const ViewComp = view(MyCustomCompName);
53+
const ViewComp = MyCustomCompName;
5454

5555
const errorSpy = jest
5656
.spyOn(console, 'error')
57-
.mockImplementation((message) =>
58-
expect(message.indexOf('Failed prop type')).not.toBe(-1),
59-
);
57+
.mockImplementation((warning, prop, error) => {
58+
expect(warning).toBe('Warning: Failed %s type: %s%s');
59+
expect(prop).toBe('prop');
60+
expect(error).toBe(
61+
'The prop `name` is marked as required in `MyCustomCompName`, but its value is `undefined`.',
62+
);
63+
});
64+
expect(1).toBe(1);
6065
render(<ViewComp number="Bob" />);
6166
expect(errorSpy).toHaveBeenCalled();
6267
errorSpy.mockRestore();
@@ -75,9 +80,13 @@ describe('static props', () => {
7580

7681
const errorSpy = jest
7782
.spyOn(console, 'error')
78-
.mockImplementation((message) =>
79-
expect(message.indexOf('Failed prop type')).not.toBe(-1),
80-
);
83+
.mockImplementation((warning, prop, error) => {
84+
expect(warning).toBe('Warning: Failed %s type: %s%s');
85+
expect(prop).toBe('prop');
86+
expect(error).toBe(
87+
'Invalid prop `number` of type `string` supplied to `MyCustomCompName`, expected `number`.',
88+
);
89+
});
8190
render(<ViewComp number="Bob" />);
8291
expect(errorSpy).toHaveBeenCalled();
8392
errorSpy.mockRestore();

package-lock.json

Lines changed: 11 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@
103103
"no-hook-react-testing-library": "npm:[email protected]",
104104
"nyc": "^15.1.0",
105105
"prettier": "^2.2.1",
106-
"react": "^16.12.0",
107-
"react-dom": "^16.13.0",
106+
"react": "^17.0.1",
107+
"react-dom": "^17.0.1",
108108
"react-native": "^0.63.4",
109109
"react-router-dom": "^5.2.0",
110110
"react-test-renderer": "^17.0.1",

0 commit comments

Comments
 (0)