Fix non-version dependent deprecations

staabm · staabm · commit 3fb2a1c9270f · 2024-03-23T15:14:55.000+01:00
diff --git a/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php b/src/SourceLocator/SourceStubber/PhpStormStubsSourceStubber.php
@@ -692,12 +692,10 @@ private function isDeprecatedByPhpDocInPhpVersion(Node\Expr\FuncCall $node): boo
             $patch     = $matches[3] ?? 0;
             $versionId = sprintf('%d%02d%02d', $major, $minor, $patch);
 
-            if ($this->phpVersion >= $versionId) {
-                return true;
-            }
+            return $this->phpVersion >= $versionId;
         }
 
-        return false;
+        return true;
     }
 
     private function isDeprecatedInPhpVersion(Node\Stmt\ClassLike|Node\Stmt\ClassConst|Node\Stmt\Property|Node\Stmt\ClassMethod|Node\Stmt\Function_ $node): bool

Original file line number	Diff line number	Diff line change
`@@ -692,12 +692,10 @@ private function isDeprecatedByPhpDocInPhpVersion(Node\Expr\FuncCall $node): boo`
`692`	`692`	`$patch = $matches[3] ?? 0;`
`693`	`693`	`$versionId = sprintf('%d%02d%02d', $major, $minor, $patch);`
`694`	`694`
`695`		`- if ($this->phpVersion >= $versionId) {`
`696`		`- return true;`
`697`		`- }`
	`695`	`+ return $this->phpVersion >= $versionId;`
`698`	`696`	`}`
`699`	`697`
`700`		`- return false;`
	`698`	`+ return true;`
`701`	`699`	`}`
`702`	`700`
`703`	`701`	`private function isDeprecatedInPhpVersion(Node\Stmt\ClassLike\|Node\Stmt\ClassConst\|Node\Stmt\Property\|Node\Stmt\ClassMethod\|Node\Stmt\Function_ $node): bool`